Opened 10 years ago

Closed 6 years ago

#3884 closed Uncategorized (wontfix)

humanize filter `intcomma` should be renamed to `numcomma`

Reported by: Chris Beaven Owned by: Adrian Holovaty
Component: Contrib apps Version: master
Severity: Normal Keywords:
Cc: lidaobing@… Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX:

Description

The current filter name doesn't give it justice (it also comma separates floats).

Backwards compatibility is easy, and it'd be good to provide a documentation example of it handling a float.

#3017 was the inspiration for this ticket.

Change History (5)

comment:1 Changed 10 years ago by Chris Beaven

Triage Stage: UnreviewedDesign decision needed

What does core think?

comment:2 Changed 10 years ago by Adrian Holovaty

Resolution: wontfix
Status: newclosed

I'm not necessarily against renaming the filter, but I don't think commaseparate is a great name because of the tendency for people to misspell "separate". Reopen with another name if you can think of one.

comment:3 Changed 8 years ago by anonymous

Cc: lidaobing@… added

comment:4 Changed 6 years ago by Ben Davis

Easy pickings: set
Resolution: wontfix
Severity: Normal
Status: closedreopened
Summary: humanize filter `intcomma` should be renamed to `commaseparate`humanize filter `intcomma` should be renamed to `numcomma`
Type: Uncategorized

How about "numcomma"?

Last edited 6 years ago by Ben Davis (previous) (diff)

comment:5 Changed 6 years ago by Russell Keith-Magee

Resolution: wontfix
Status: reopenedclosed

At this point in Django's life, I'm not sure I see the value in changing the name. It might not be the most accurate name in the world, but it isn't fundamentally broken, and changing it would require a whole bunch of deprecation/backwards compatibility dancing for what is, at the end of the day, not a whole lot of gain.

If the name change was required in the context of some clarification of what intcomma actually does, I might be convinced, but if were doing it just for the sake of theoretical purity, I think we can pass.

Note: See TracTickets for help on using tickets.
Back to Top