Opened 8 years ago

Closed 4 years ago

#3884 closed Uncategorized (wontfix)

humanize filter `intcomma` should be renamed to `numcomma`

Reported by: SmileyChris Owned by: adrian
Component: Contrib apps Version: master
Severity: Normal Keywords:
Cc: lidaobing@… Triage Stage: Design decision needed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX:

Description

The current filter name doesn't give it justice (it also comma separates floats).

Backwards compatibility is easy, and it'd be good to provide a documentation example of it handling a float.

#3017 was the inspiration for this ticket.

Change History (5)

comment:1 Changed 8 years ago by SmileyChris

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

What does core think?

comment:2 Changed 8 years ago by adrian

  • Resolution set to wontfix
  • Status changed from new to closed

I'm not necessarily against renaming the filter, but I don't think commaseparate is a great name because of the tendency for people to misspell "separate". Reopen with another name if you can think of one.

comment:3 Changed 7 years ago by anonymous

  • Cc lidaobing@… added

comment:4 Changed 4 years ago by bendavis78

  • Easy pickings set
  • Resolution wontfix deleted
  • Severity set to Normal
  • Status changed from closed to reopened
  • Summary changed from humanize filter `intcomma` should be renamed to `commaseparate` to humanize filter `intcomma` should be renamed to `numcomma`
  • Type set to Uncategorized

How about "numcomma"?

Last edited 4 years ago by bendavis78 (previous) (diff)

comment:5 Changed 4 years ago by russellm

  • Resolution set to wontfix
  • Status changed from reopened to closed

At this point in Django's life, I'm not sure I see the value in changing the name. It might not be the most accurate name in the world, but it isn't fundamentally broken, and changing it would require a whole bunch of deprecation/backwards compatibility dancing for what is, at the end of the day, not a whole lot of gain.

If the name change was required in the context of some clarification of what intcomma actually does, I might be convinced, but if were doing it just for the sake of theoretical purity, I think we can pass.

Note: See TracTickets for help on using tickets.
Back to Top