Opened 10 years ago

Closed 10 years ago

#3822 closed (fixed)

core.management.get_indexes_for_model does not quote index names

Reported by: Robin Breathe <robin@…> Owned by: Adrian Holovaty
Component: Core (Management commands) Version: master
Severity: Keywords: sqlindexes
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

If you're model's column names require quoting, the chances are high that the auto-generated index names will also require quoting (this bit me with a column named "user@realm").

Without this patch, manage.py sqlindexes (and the other functions which implicitly call core.management.get_indexs_for_model) may generate invalid output.

Attachments (1)

quote_index.diff (766 bytes) - added by Robin Breathe <robin@…> 10 years ago.
patch

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by Robin Breathe <robin@…>

Attachment: quote_index.diff added

patch

comment:1 Changed 10 years ago by Simon G. <dev@…>

Triage Stage: UnreviewedReady for checkin

comment:2 Changed 10 years ago by Adrian Holovaty

Resolution: fixed
Status: newclosed

(In [4835]) Fixed #3822 -- Changed get_indexes_for_model() in django.core.management to quote index names. Thanks, Robin Breathe

Note: See TracTickets for help on using tickets.
Back to Top