Code

Opened 7 years ago

Closed 6 years ago

#3759 closed (worksforme)

Community aggregator update_feed.py uses wrong encoding

Reported by: derelm Owned by: nobody
Component: *.djangoproject.com Version: master
Severity: Keywords:
Cc: Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

I actually fell over that problem, when i duplicated the code in djangoproject.com/django_website/apps/aggregator/bin/update_feeds.py on my website. the fetched feed-data is converted back to the encoding it used to be instead of being converted to UTF-8.

i am not really into encodings that much, so i'd love to get a comment of someone with a little more knowledge in that area.

Attachments (1)

update_feeds.diff (1.3 KB) - added by derelm 7 years ago.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by derelm

comment:1 Changed 7 years ago by Simon G. <dev@…>

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

comment:2 Changed 7 years ago by jacob

  • Resolution set to invalid
  • Status changed from new to closed

This doesn't look right to me... it assumes that all feeds are in UTF8, which is wrong.

comment:3 Changed 7 years ago by derelm

i tested it for quite some time with all sorts of feeds all over the web, works perfectly fine for me.

btw, also tested with non utf-8 feeds.

comment:4 Changed 7 years ago by derelm

  • Resolution invalid deleted
  • Status changed from closed to reopened

it assumes that the output of feedparser is utf8 which is almost always true...

can someone from unicode-branch comment?

comment:5 Changed 6 years ago by jacob

  • Resolution set to worksforme
  • Status changed from reopened to closed

The code works for this website, which is all it's intended for.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.