Opened 3 weeks ago

Last modified 2 weeks ago

#37380 new New feature

FromWKB() and FromWKT() should support the SRID param on Oracle

Reported by: Jacob Walls Owned by: Jacob Walls
Component: GIS Version: dev
Severity: Normal Keywords: oracle geodjango
Cc: Loïc LEFEVRE Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

The source for FromWKB() and FromWKT() ​says that the srid param will be ignored on Oracle, but it ​exists on both since Oracle19c, so we should just add support.

Change History (7)

comment:1 by Jacob Walls, 3 weeks ago

Has patch: set

comment:2 by Natalia Bidart, 3 weeks ago

Resolution: → needsinfo
Status: assigned → closed

Thanks Jacob! Though I can't confirm that the srid param exists in Oracle 19c GA, the link you shared is for 26 I think. I tried confirming via LLMs and all I got was:

The linked docs are for 26ai. The current 19c reference (​https://docs.oracle.com/en/database/oracle/oracle-database/19/spatl/SDO_UTIL-reference.html) also lists the srid argument for both functions, but the 21c docs only show the single-argument form, which suggests it was added in a 19c release update rather than in 19c GA. Do we know the minimum 19c Release Update that supports it?

I can't tell either from the Jenkins run since the Oracle (GIS) tests have setUpClass failures. Am I missing something?

comment:3 by Jacob Walls, 3 weeks ago

Cc: Loïc LEFEVRE added

Good point about the support possibly missing in GA, let's ask Loïc. In other ​cases, we've just raised the minimum version to the point where we have certainty.

Loïc, would you know when the srid parameter was first available on these functions?

comment:4 by Loïc LEFEVRE, 3 weeks ago

First I can tell you these srid parameters are still not present in the latest Release Update of 21c (21.23). Moreover 21c being an innovation release, do not count of having these changes provided inside 21c. Note that the support will end by 31st July 2027 and no extended support will be provided (because again this is an innovation release and not a long term release like 19c or 26ai).

I'm looking now for the precise Release Update where this was introduced in 19c...

comment:5 by Loïc LEFEVRE, 2 weeks ago

The introduction of these srid parameters was done in RU 19.25.

comment:6 by Jacob Walls, 2 weeks ago

Resolution: needsinfo
Status: closed → new

Thanks. (We should probably discuss separately dropping support for 21c in Django 6.2.)

comment:7 by Natalia Bidart, 2 weeks ago

Keywords: oracle geodjango added
Triage Stage: Unreviewed → Accepted

Given #37391, I'm accepting this for 6.2 assuming we increase the minimum support of Oracle to 26.

Note: See TracTickets for help on using tickets.
Back to Top