Add Links for ImageField and FileField in admin_list.py

[nicholasdsj@…]

When I added ImageField or FileField to list_display_links, the result was not what I expected.

I saw the code in admin_list.py, the function items_for_result, there was no check for ImageField and FileFiled, I suggested to add following snippts:

# Line 176
            elif isinstance(f, models.ImageField) or isinstance(f, models.FileField):
                if field_val is not None:
                    result_repr = ('<a href="%s	%s">%s</a>' % (settings.MEDIA_URL, field_val, field_val))
                else:
                    result_repr = EMPTY_CHANGELIST_VALUE

I hope the django team can consider about that.

Thanks in advance.

[Thomas Kerpe]

According to the docs:
"Set list_display_links to control which fields in list_display should be linked to the “change” page for an object."

So its wrong to link to the image or file itself!

[Thomas Kerpe]

After discussion at #django-sprint this ticket was closed. Why it's reopened?

[Michael Radziej <mir@…>]

Without looking into the details: No anonymous reopening is permitted, and please also state a reason.