Opened 3 weeks ago

Closed 4 days ago

#37182 closed Cleanup/optimization (fixed)

non-existent DOM properties used in skip link to content selenium test

Reported by: Varun Kasyap Pentamaraju Owned by: Varun Kasyap Pentamaraju
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

in admin_views.test_skip_link_to_content.PlaywrightTests.test_skip_link_with_RTL_language_doesnt_create_horizontal_scrolling

horizontal scroll check uses non-existent DOM properties (scrollWeight / offsetWeight) instead of scrollWidth / offsetWidth.

            is_vertical_scrolleable = self.selenium.execute_script(
                "return arguments[0].scrollHeight > arguments[0].offsetHeight;", body
            )
            is_horizontal_scrolleable = self.selenium.execute_script(
                "return arguments[0].scrollWeight > arguments[0].offsetWeight;", body
            )
            self.assertTrue(is_vertical_scrolleable)
            self.assertFalse(is_horizontal_scrolleable)

undefined > undefined is always false. so, assertFalse always passes

Change History (4)

comment:1 by Tim Graham, 3 weeks ago

Triage Stage: Unreviewed → Accepted

comment:2 by Varun Kasyap Pentamaraju, 3 weeks ago

Has patch: set

​https://github.com/django/django/pull/21528

comment:3 by Sarah Boyce, 4 days ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Sarah Boyce <42296566+sarahboyce@…>, 4 days ago

Resolution: → fixed
Status: assigned → closed

In 4106acd1:

Fixed #37182 -- Corrected property typo in skip link to content test.

Note: See TracTickets for help on using tickets.
Back to Top