Opened 3 weeks ago

Closed 4 days ago

#37181 closed Cleanup/optimization (fixed)

History view Selenium test uses assertTrue instead of assertEqual

Reported by: Varun Kasyap Pentamaraju Owned by: Varun Kasyap Pentamaraju
Component: contrib.admin Version: dev
Severity: Normal Keywords:
Cc: Varun Kasyap Pentamaraju Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

in admin_views.test_history_view.SeleniumTests.test_pagination,

there is an assertion that check last page pagination number.

self.assertTrue(last_page_link.text, "20")

but, seems like it is intended to be assertEqual()

also, setUp creates 1100 records. with admin page size of 100, the last page should be "11", not "20".

Change History (4)

comment:1 by Tim Graham, 3 weeks ago

Triage Stage: Unreviewed → Accepted

Probably you can make typo fixes like this without a ticket.

comment:2 by Varun Kasyap Pentamaraju, 3 weeks ago

Has patch: set

​https://github.com/django/django/pull/21527

comment:3 by Sarah Boyce, 4 days ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Sarah Boyce <42296566+sarahboyce@…>, 4 days ago

Resolution: → fixed
Status: assigned → closed

In f5134796:

Fixed #37181 -- Corrected assertion in SeleniumTests.test_pagination.

Note: See TracTickets for help on using tickets.
Back to Top