Opened 4 weeks ago
Closed 4 weeks ago
#37046 closed Bug (fixed)
PR Quality check may need to account for ready for check-in
| Reported by: | Tim Schilling | Owned by: | Varun Kasyap Pentamaraju |
|---|---|---|---|
| Component: | Core (Other) | Version: | dev |
| Severity: | Release blocker | Keywords: | GitHub Actions |
| Cc: | JaeHyuckSa, Natalia Bidart | Triage Stage: | Accepted |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
This is in reference to PR 21041
I reviewed @Afenomamy's PR and it looks ready to go. According to the contribution docs, I'm supposed to mark it as ready for check-in. I did so, but then it was flagged by the bot. Reviewing the code for check_pr.py, there isn't an exception for this state. I suspect there should be.
Change History (10)
comment:1 by , 4 weeks ago
| Cc: | added |
|---|---|
| Severity: | Normal → Release blocker |
| Triage Stage: | Unreviewed → Accepted |
comment:2 by , 4 weeks ago
| Component: | Uncategorized → Core (Other) |
|---|
comment:3 by , 4 weeks ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
comment:4 by , 4 weeks ago
| Has patch: | set |
|---|
comment:5 by , 4 weeks ago
| Cc: | added; removed |
|---|
comment:7 by , 4 weeks ago
| Patch needs improvement: | set |
|---|
comment:10 by , 4 weeks ago
| Cc: | added |
|---|
comment:11 by , 4 weeks ago
If not self-evident, there are a couple places where more actions happen after marking a ticket RFC that will re-trigger the action:
- merger wants to trigger more tests, so they apply the Selenium or coverage labels
- author pushes again to add themselves to AUTHORS
- merger force-pushes to edit commit messages etc.
comment:12 by , 4 weeks ago
| Patch needs improvement: | unset |
|---|
Note:
See TracTickets
for help on using tickets.
https://github.com/django/django/pull/21129