Opened 4 weeks ago

Last modified 3 weeks ago

#37045 assigned New feature

Deprecate and rename django.db.transaction.savepoint

Reported by: Lily Owned by: Samuel Searles-Bryant
Component: Database layer (models, ORM) Version:
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

I proposed this in ​https://github.com/django/new-features/issues/138 and it is now accepted.

Rename savepoint to savepoint_create and add a new savepoint function as a deprecated alias or wrapper for savepoint_create. Once the deprecation period has ended remove savepoint. This will free the name for use for a higher-level savepoint context manager.

Change History (6)

comment:1 by Lily, 4 weeks ago

Triage Stage: Unreviewed → Accepted

comment:2 by Samuel Searles-Bryant, 4 weeks ago

Owner: set to Samuel Searles-Bryant
Status: new → assigned

comment:3 by Samuel Searles-Bryant, 4 weeks ago

BaseDatabaseWrapper also has a savepoint method (and a private _savepoint). We could also rename those, but that's not necessary.

comment:4 by Samuel Searles-Bryant, 4 weeks ago

Has patch: set

comment:5 by Lily, 4 weeks ago

Triage Stage: Accepted → Ready for checkin

comment:6 by Mariusz Felisiak, 3 weeks ago

Patch needs improvement: set
Triage Stage: Ready for checkin → Accepted
Note: See TracTickets for help on using tickets.
Back to Top