fields.E348 check should check against the accessor_name instead of the model name

[nick.ma@…]

when running manage.py I hit erroneous fields.E348 check. The system check is supposed to examine if ManyToOne/ManyToMany field <related_name> for <model>.<field name> clashes with the name of a model manager. However, instead of checking the related_name (i.e. <fieldname>_set or manually set related_name=<related_name>) it gets the actual field name of the foreign key.

As shown in the original check function below

    def _check_conflict_with_managers(self):
        errors = []
        manager_names = {manager.name for manager in self.opts.managers}
        for rel_objs in self.model._meta.related_objects:
            related_object_name = rel_objs.name
            if related_object_name in manager_names:
                field_name = f"{self.model._meta.object_name}.{self.name}"
                errors.append(
                    checks.Error(
                        f"Related name '{related_object_name}' for '{field_name}' "
                        "clashes with the name of a model manager.",
                        hint=(
                            "Rename the model manager or change the related_name "
                            f"argument in the definition for field '{field_name}'."
                        ),
                        obj=self,
                        id="fields.E348",
                    )
                )
        return errors

it compares a model's managers' name and its related object field name.

related_object_name = rel_objs.name

Patch:
It should use the .accessor_name instead of .name

diff --git a/django/db/models/fields/related.py b/django/db/models/fields/related.py
index f1bc664007..a3ef912a8e 100644
--- a/django/db/models/fields/related.py
+++ b/django/db/models/fields/related.py
@@ -723,7 +723,7 @@ class ForeignObject(RelatedField):
         errors = []
         manager_names = {manager.name for manager in self.opts.managers}
         for rel_objs in self.model._meta.related_objects:
-            related_object_name = rel_objs.name
+            related_object_name = rel_objs.accessor_name
             if related_object_name in manager_names:
                 field_name = f"{self.model._meta.object_name}.{self.name}"
                 errors.append(

[Shubh Rai]

I have made a pr: ​https://github.com/django/django/pull/20846 . Please feel free to tell me any changes that are required , any feedback would be appreciated.

[Clifford Gama]

While investigating this ticket, I discovered that the patch added in #22977 only identifies a clash between an accessor and a manager if the relationship is self-referential. The attempt to fix that issue made it easier to understand the issue reported here. I opened an ​alternative PR to fix both issues.

[Jacob Walls]

I think we can add one test case for the issue discovered in review, but otherwise this is good to go.

[Jacob Walls]

Ah, it was already accounted for!

[Jacob Walls]

Actually, this is a bug in 6.0, so we need a release note so we can backport before Tuesday.

[Jacob Walls <jacobtylerwalls@…>]

In fcf91688:

Fixed #36973 -- Made fields.E348 check detect further clashes between managers and related_names.

Clashes were only detected for self-referential relationships, i.e. ForeignKey("self").

Refs #22977. Bug in 6888375c53476011754f778deabc6cdbfa327011.

Thanks JaeHyuckSa for the thorough review!

[Jacob Walls <jacobtylerwalls@…>]

In 4eb38f6:

[6.0.x] Fixed #36973 -- Made fields.E348 check detect further clashes between managers and related_names.

Clashes were only detected for self-referential relationships, i.e. ForeignKey("self").

Refs #22977. Bug in 6888375c53476011754f778deabc6cdbfa327011.

Thanks JaeHyuckSa for the thorough review!

Backport of fcf916884d25ed430bd7cedaea2b10035c2aa3b6 from main.