No validation error when ForeignKey related_name clashes with manager name.

[Russell Keith-Magee]

Consider the following model definition:

class Author(models.Model):
    authors = models.Manager()

    name = models.CharField(max_length=100)

    mentor = models.ForeignKey('self', related_name='authors')

The related name on the the foreign key clashes with the manager, so when you try to issue a query:

    Author.authors.filter(name__startswith='Douglas')

you get an error because "Author.authors has no attribute 'filter'".

The problem is order dependent; if you define the manager *after* the foreign key, you get different errors.

I haven't checked what errors you get if you just have the default Manager, and a related_name of 'objects'.

There may also be problems if you have a field named 'objects'.

I suspect this class of problem could be picked up by the system check framework.

[Tim Graham]

As Loic noted on the PR, we should revisit this after the _meta factor is merged.

[Davide Ceretti]

Given loic's comment at ​https://github.com/django/django/pull/3359#issuecomment-59642918, what would be the correct implementation of this validation check? Adding it to BaseManager.check method?

[Mariusz Felisiak]

I will finish it.

[Johanan Oppong Amoateng]

Replying to Mariusz Felisiak:

I will finish it.

Hey Mariusz Felisiak are you still working on this? If not i would like to pick it up

[Mariusz Felisiak]

Replying to Johanan Oppong Amoateng:

Replying to Mariusz Felisiak:

I will finish it.

Hey Mariusz Felisiak are you still working on this? If not i would like to pick it up

It's only 9 days, pretty early to ask. I'll finish it in the coming days.

[Mariusz Felisiak]

New ​PR.

[Mariusz Felisiak <felisiak.mariusz@…>]

In 6888375c:

Fixed #22977 -- Added system check for clashing managers and reverse related fields.

With thanks to Konrad Świat, Loïc Bistuer, Russell Keith-Magee,
and Mariusz Felisiak.

Co-authored-by: Mariusz Felisiak <felisiak.mariusz@…>