Opened 3 weeks ago

Closed 2 days ago

#36914 closed Bug (fixed)

Inconsistent option background color in M2M select widget for TabularInline.

Reported by: Antoliny Owned by: Antoliny
Component: contrib.admin Version: 6.0
Severity: Normal Keywords: accessibility
Cc: jaffar Khan Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

In #35809, the select widget option background color was changed (to improve color contrast).


It seems that the changed color is not being applied to fields within TabularInline.

Attachments (2)

background_color_example.png​ (52.8 KB ) - added by Antoliny 3 weeks ago.
Background.png​ (14.3 KB ) - added by jaffar Khan 3 weeks ago.

Download all attachments as: .zip

Change History (16)

by Antoliny, 3 weeks ago

Attachment: background_color_example.png​ added

comment:1 by Antoliny, 3 weeks ago

Owner: set to Antoliny
Status: new → assigned

comment:2 by Antoliny, 3 weeks ago

Has patch: set

​PR

by jaffar Khan, 3 weeks ago

Attachment: Background.png​ added

comment:3 by jaffar Khan, 3 weeks ago

Has patch: unset

In reproducing this bug I noticed that tabularInline background color contrast of selected rows is very poor, the text can't be read when we select rows:

comment:4 by jaffar Khan, 3 weeks ago

Cc: jaffar Khan added
Has patch: set

comment:5 by Jacob Walls, 3 weeks ago

Thanks for the report -- do you have a test model or a unit test, or a reproducer I can check out?

in reply to:  3 comment:6 by Antoliny, 3 weeks ago

Replying to jaffar Khan:

In reproducing this bug I noticed that tabularInline background color contrast of selected rows is very poor, the text can't be read when we select rows:

Yes, that's right. It's an issue caused by the default font color in Edge browser.
A related ticket(#36513) already exists!

comment:7 by Jacob Walls, 3 weeks ago

Needs tests: set

I couldn't find evidence of a TabularInline with a ManyToManyField in the admin_views screenshots tests, but maybe Antoliny knows of one?

comment:8 by Jacob Walls, 3 weeks ago

Triage Stage: Unreviewed → Accepted

comment:9 by Antoliny, 4 days ago

Needs tests: unset

comment:10 by Antoliny, 4 days ago

I couldn't find evidence of a TabularInline with a ManyToManyField in the admin_views screenshots tests, but maybe Antoliny knows of one?

Yes, I think it needs testing.

comment:11 by Jacob Walls, 3 days ago

Patch needs improvement: set

A merge conflict to address.

comment:12 by Antoliny, 2 days ago

Patch needs improvement: unset

comment:13 by Jacob Walls, 2 days ago

Triage Stage: Accepted → Ready for checkin

comment:14 by Jacob Walls <jacobtylerwalls@…>, 2 days ago

Resolution: → fixed
Status: assigned → closed

In 2166486:

Fixed #36914 -- Fixed background-color to also apply to select options in TabularInline.

Note: See TracTickets for help on using tickets.
Back to Top