Opened 43 hours ago

Last modified 41 hours ago

#35809 new Bug

Background color for admin's m2m multi-select "selected" rows is lost in dark theme

Reported by: Giannis Terzopoulos Owned by:
Component: contrib.admin Version: 5.1
Severity: Release blocker Keywords:
Cc: Thibaud Colas, Tom Carrick, Sarah Abderemane, Eliana Rosselli Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

I noticed today that the color that is currently used for selected m2m items is indistinguishable. It might not be as noticeable to others, I'm not sure, I have some color difficulties. Only dark theme seems to be affected.

I am attaching 2 screenshots, how it looks on 5.1 and on 5.0.9

Attachments (2)

django_5.1.png​ (5.3 KB ) - added by Giannis Terzopoulos 43 hours ago.
django_5.0.9.png​ (5.3 KB ) - added by Giannis Terzopoulos 43 hours ago.

Download all attachments as: .zip

Change History (5)

by Giannis Terzopoulos, 43 hours ago

Attachment: django_5.1.png​ added

by Giannis Terzopoulos, 43 hours ago

Attachment: django_5.0.9.png​ added

comment:1 by Natalia Bidart, 41 hours ago

Cc: eroselli added
Component: Uncategorized → contrib.admin
Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted
Type: Uncategorized → Bug
UI/UX: set

Hello Giannis, thank you for your report!

I have tried to reproduce and these are my findings:

  • in Chrome, both light and dark mode have good contrast for the selected m2m, both when the m2m widget has focus and when it does not.
  • in Firefox, when using the dark theme, there is good contrast for when the m2m widget has focus but there is no color difference when the focus is moved to another element.

I bisected the regressing revno to be b47bdb4cd9149ee2a39bf1cc9996a36a940bd7d9

Would you like to prepare a patch?

comment:2 by Natalia Bidart, 41 hours ago

Cc: Thibaud Colas Tom Carrick Sarah Abderemane Eliana Rosselli added; eroselli removed

Added Accessibility team as cc, would you have any recommendation?

comment:3 by Natalia Bidart, 41 hours ago

Summary: Improved background color for admin's m2m multi-select → Background color for admin's m2m multi-select "selected" rows is lost in dark theme
Note: See TracTickets for help on using tickets.
Back to Top