Opened 6 weeks ago

Closed 6 days ago

#36887 closed Cleanup/optimization (fixed)

Unnecessary space introduced at top of changelist pages in 6.0

Reported by: Jacob Walls Owned by: Jacob Walls
Component: contrib.admin Version: 6.0
Severity: Normal Keywords:
Cc: Antoliny Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

See ​report and screenshot, #36055 solved an overlap issue at the top of changelist pages by splitting the header and action button into two rows, when we could have just used flex layout to fix the overlap.

I have a patch ready along those lines.

Change History (11)

comment:1 by Natalia Bidart, 6 weeks ago

Triage Stage: Unreviewed → Accepted
UI/UX: set

Thank you!

comment:2 by Jacob Walls, 6 weeks ago

Well, my intended fix just re-causes #36331. I'm not sure we should have closed with #36331 with a revert; we could have just doc'd it. django-filer (source of bug report) already coped with the change, see ​PR.

What is our backwards compatibility guarantee for extending admin template blocks?

comment:3 by Jacob Walls, 6 weeks ago

Has patch: set
Needs tests: set
Severity: Release blocker → Normal

Given that the best solution here involves a change to template composition, I'm not convinced we should backport. I already have something ready for discussion, so I'll post it anyway as a ​draft PR.

It's just a little whitespace; we can defer it to 6.1 and ensure more testing occurs.

comment:4 by Jacob Walls, 4 weeks ago

Needs tests: unset

comment:5 by Jacob Walls, 4 weeks ago

Type: Bug → Cleanup/optimization

comment:6 by Antoliny, 4 weeks ago

Patch needs improvement: set

comment:7 by Jacob Walls, 4 weeks ago

Patch needs improvement: unset

comment:8 by Jacob Walls, 11 days ago

Patch needs improvement: set

comment:9 by Jacob Walls, 6 days ago

Patch needs improvement: unset

comment:10 by Antoliny, 6 days ago

Triage Stage: Accepted → Ready for checkin

comment:11 by Jacob Walls <jacobtylerwalls@…>, 6 days ago

Resolution: → fixed
Status: assigned → closed

In 35dab0ad:

Fixed #36887 -- Improved admin changelist layout for object-tools button.

Note: See TracTickets for help on using tickets.
Back to Top