Opened 9 months ago

Closed 8 weeks ago

#36055 closed Bug (fixed)

Admin change form object-tools buttons cover part of the h2 title when the latter occupies multiple lines

Reported by: ldeluigi Owned by: Antoliny
Component: contrib.admin Version: 5.1
Severity: Normal Keywords: object-tools object tools admin css buttons
Cc: ldeluigi Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

The culprit seems to be the margin-top: -48px set up at ​https://github.com/django/django/blob/8d9901c961bf9d5cfa6bddddbbcebfbf487a5125/django/contrib/admin/static/admin/css/base.css#L776C1-L776C2

https://github.com/user-attachments/assets/ab2c2c09-195b-4ba0-a106-2096f2c3ed87

Change History (23)

comment:1 by Sarah Boyce, 9 months ago

Summary: Object tools CSS makes buttons cover part of the h2 title when the latter occupies multiple lines → Admin change form object-tools buttons cover part of the h2 title when the latter occupies multiple lines
Triage Stage: Unreviewed → Accepted

Replicated. I would probably move the object-tools section below the h1, but above the h2 and still remove the margin. This will need some playing around with

comment:2 by Antoliny, 9 months ago

Owner: set to Antoliny
Status: new → assigned

comment:3 by Antoliny, 8 months ago

Has patch: set

comment:5 by Sarah Boyce, 8 months ago

Needs tests: set

comment:6 by Antoliny, 8 months ago

Needs tests: unset

comment:7 by Sarah Boyce, 8 months ago

Triage Stage: Accepted → Ready for checkin

comment:8 by Sarah Boyce <42296566+sarahboyce@…>, 8 months ago

Resolution: → fixed
Status: assigned → closed

In b1324a68:

Fixed #36055 -- Prevented overlap of object-tools buttons and page header in the admin.

comment:9 by Sarah Boyce <42296566+sarahboyce@…>, 8 months ago

In d03102a5:

[5.2.x] Fixed #36055 -- Prevented overlap of object-tools buttons and page header in the admin.

Backport of b1324a680add78de24c763911d0eefa19b9263bc from main.

comment:10 by Sarah Boyce <42296566+sarahboyce@…>, 6 months ago

In 02a5cbfe:

Refs #36055 -- Prevented overlap of object-tools buttons and page header in the admin on small screens.

Visual regression in b1324a680add78de24c763911d0eefa19b9263bc.

comment:11 by Sarah Boyce <42296566+sarahboyce@…>, 6 months ago

In 9898b2d0:

[5.2.x] Refs #36055 -- Prevented overlap of object-tools buttons and page header in the admin on small screens.

Visual regression in b1324a680add78de24c763911d0eefa19b9263bc.

Backport of 02a5cbfe76382da2a0414df17017185be5bd47f9 from main.

comment:12 by nessita <124304+nessita@…>, 5 months ago

In 1bc805e:

Fixed #36331 -- Reverted "Fixed #36055 -- Prevented overlap of object-tools buttons and page header in the admin."

This reverts commits b1324a680add78de24c763911d0eefa19b9263bc and
02a5cbfe76382da2a0414df17017185be5bd47f9. The former caused a regression
in admin sites that relied on the object-tools block being inside the
content block.

Thank you to Fabian Braun for the report.

comment:13 by Natalia <124304+nessita@…>, 5 months ago

In 97c9354:

[5.2.x] Fixed #36331 -- Reverted "Fixed #36055 -- Prevented overlap of object-tools buttons and page header in the admin."

This reverts commits b1324a680add78de24c763911d0eefa19b9263bc and
02a5cbfe76382da2a0414df17017185be5bd47f9. The former caused a regression
in admin sites that relied on the object-tools block being inside the
content block.

Thank you to Fabian Braun for the report.

Backport of 1bc805e23b73a580b82a1d416ab0fb59a1073047 from main.

comment:14 by Natalia Bidart, 5 months ago

Has patch: unset
Resolution: fixed
Status: closed → new
Triage Stage: Ready for checkin → Accepted

Reopening after the reverts.

comment:15 by Antoliny, 5 months ago

Status: new → assigned

comment:16 by Antoliny, 2 months ago

Has patch: set

​New PR

comment:17 by Sarah Boyce, 2 months ago

Triage Stage: Accepted → Ready for checkin

comment:18 by Sarah Boyce, 2 months ago

Patch needs improvement: set
Triage Stage: Ready for checkin → Accepted

comment:19 by Antoliny, 2 months ago

Patch needs improvement: unset

comment:20 by Sarah Boyce, 2 months ago

Patch needs improvement: set

(Requires doc image updates)

comment:21 by Antoliny, 2 months ago

Patch needs improvement: unset

​NEW PR

comment:22 by Sarah Boyce, 8 weeks ago

Triage Stage: Accepted → Ready for checkin

comment:23 by Sarah Boyce <42296566+sarahboyce@…>, 8 weeks ago

Resolution: → fixed
Status: assigned → closed

In 94c2f3b9:

Fixed #36055 -- Prevented overlap of object-tools buttons and page header in the admin.

Note: See TracTickets for help on using tickets.
Back to Top