Opened 2 months ago
Last modified 7 weeks ago
#36829 closed Bug
Breaking change in ClearableFileInput — at Initial Version
| Reported by: | Johannes Maron | Owned by: | |
|---|---|---|---|
| Component: | Forms | Version: | 6.0 |
| Severity: | Release blocker | Keywords: | fieldset, legend |
| Cc: | Johannes Maron, Antoliny, David Smith | Triage Stage: | Ready for checkin |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | yes |
Description
Howdy y'all,
#35892 flipped django.forms.widgets.ClearableFileInput.use_fieldset from false to true.
This changes the form rendering outside the admin too. Probably just a small oversight and not an intentional change, since changes weren't accompanied by release notes.
Anyhow, both the input and the use_fieldset are part of the public documentation, and changes must undergo deprecation.
The problem gets amplified with #36828, since the current fieldset implementation violates HTML and WCAG 2.1
The only affected version is 6.0. I would recommend providing a regression patch in the next bugfix release.
Cheers!
Joe
Note:
See TracTickets
for help on using tickets.