Breaking change in ClearableFileInput

[Johannes Maron]

Howdy y'all,

#35892 flipped django.forms.widgets.ClearableFileInput.use_fieldset from false to true.

The change can be found here: ​https://github.com/django/django/blame/4187da258fe212d494cb578a0bc2b52c4979ab95/django/forms/widgets.py#L533

This changes the form rendering outside the admin too. Probably just a small oversight and not an intentional change, since changes weren't accompanied by release notes.

Anyhow, both the input and the use_fieldset are part of the public documentation, and changes must undergo deprecation.

The problem gets amplified with #36828, since the current fieldset implementation violates HTML and WCAG 2.1

The only affected version is 6.0. I would recommend providing a regression patch in the next bugfix release.

Cheers!
Joe

[Tim Graham]

It might be that only AdminFileWidget (the ClearableFileInput used in admin forms) should have that attribute.

[Antoliny]

Thank you for reporting this issue, Joe :)

In my view, using a fieldset for ClearableFileInput itself makes sense.
However, I also agree that it’s a problem that a change related to the admin affected form rendering outside of the admin as well (and that this wasn’t communicated).

As Tim suggested, should this change be limited to the admin only?

[Johannes Maron]

Agreed, let's limit the change to the admin, since its widgets aren't publicly documented.

I'll attach a potential patch.