Opened 3 weeks ago
Last modified 2 days ago
#36629 assigned Bug
In the admin m2m widget filter_vertical, the “choose all” button is missing.
| Reported by: | Antoliny | Owned by: | Md. Miftahul Kabir |
|---|---|---|---|
| Component: | contrib.admin | Version: | 5.2 |
| Severity: | Normal | Keywords: | filter_vertical |
| Cc: | Triage Stage: | Accepted | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | yes | Patch needs improvement: | no |
| Easy pickings: | yes | UI/UX: | yes |
Description
Currently, the “choose_all” button exists for filter_horizontal, but it is not available when using filter_vertical.
filter_horizontal
filter_vertical
I’m not exactly sure why the choose_all button doesn’t exist for filter_vertical.
I don’t think the “choose all” button has a significant impact on page height.
Unless there’s a specific reason, I believe the choose_all button should naturally exist for filter_vertical as well.
Additionally, the “choose all” button was also not present in versions 4.2 and 5.0.
5.0
4.2
Attachments (4)
Change History (16)
by , 3 weeks ago
| Attachment: | vertical.png added |
|---|
by , 3 weeks ago
| Attachment: | horizontal.png added |
|---|
by , 3 weeks ago
| Attachment: | vertical_5.0.png added |
|---|
by , 3 weeks ago
| Attachment: | vertical_4.2.png added |
|---|
comment:1 by , 3 weeks ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
follow-up: 3 comment:2 by , 3 weeks ago
comment:3 by , 3 weeks ago
Replying to Alex Hatfield:
Bug observed in Django 5.2.4 and 5.1.12 -> indicating this is not a regression issue, so shifting focus to addressing and implementing a fix.
Hello Alex, thank you for choosing to work on this.
However, this ticket has not been accepted yet, so it’s fine to start after it has been accepted :)
comment:4 by , 3 weeks ago
| Triage Stage: | Unreviewed → Accepted |
|---|
Perhaps this was because the buttons were not responsive (#35924), and so it makes sense to include these.
I think filter_vertical should be roughly equivalent to the mobile view of filter_horizontal
follow-up: 6 comment:5 by , 13 days ago
| Owner: | removed |
|---|---|
| Status: | assigned → new |
Hi Antoliny, thanks for the comment - apologies for causing any confusion, will be sure to wait for acceptance next time.
I haven't been able to make any progress so deassigning myself. I believe I've done this correctly but please let me know if not (apologies this is my first ticket).
comment:6 by , 13 days ago
Replying to Alex Hatfield:
Hi Antoliny, thanks for the comment - apologies for causing any confusion, will be sure to wait for acceptance next time.
I haven't been able to make any progress so deassigning myself. I believe I've done this correctly but please let me know if not (apologies this is my first ticket).
No worries Alex, thank you for giving this ticket a try!
It’s totally fine to start working before accepted — I just mentioned it because I didn’t want your efforts to go to waste in case it didn’t get accepted.
You’re welcome to pick this up again anytime! (Now that it’s accepted, as long as no one else has taken over!)
follow-up: 8 comment:7 by , 12 days ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
comment:8 by , 8 days ago
Replying to Mridul:
Hello Mridul, can I change the owner to me? I already solved this ticket for my personal practice and I was able to solve the issue. If you think it's okay then I can change the owner status to me and create a pull request.
Thank you
comment:10 by , 8 days ago
| Owner: | changed from to |
|---|
comment:12 by , 2 days ago
| Needs tests: | set |
|---|
Bug observed in Django 5.2.4 and 5.1.12 -> indicating this is not a regression issue, so shifting focus to addressing and implementing a fix.