In the admin m2m widget filter_vertical, the “choose all” button is missing.

[Antoliny]

Currently, the “choose_all” button exists for filter_horizontal, but it is not available when using filter_vertical.

filter_horizontal

filter_vertical

I’m not exactly sure why the choose_all button doesn’t exist for filter_vertical.
I don’t think the “choose all” button has a significant impact on page height.
Unless there’s a specific reason, I believe the choose_all button should naturally exist for filter_vertical as well.

Additionally, the “choose all” button was also not present in versions 4.2 and 5.0.

5.0

4.2

[Alex Hatfield]

Bug observed in Django 5.2.4 and 5.1.12 -> indicating this is not a regression issue, so shifting focus to addressing and implementing a fix.

[Antoliny]

Replying to Alex Hatfield:

Bug observed in Django 5.2.4 and 5.1.12 -> indicating this is not a regression issue, so shifting focus to addressing and implementing a fix.

Hello Alex, thank you for choosing to work on this.
However, this ticket has not been accepted yet, so it’s fine to start after it has been accepted :)

[Sarah Boyce]

Perhaps this was because the buttons were not responsive (#35924), and so it makes sense to include these.
I think filter_vertical should be roughly equivalent to the mobile view of filter_horizontal

[Alex Hatfield]

Hi Antoliny, thanks for the comment - apologies for causing any confusion, will be sure to wait for acceptance next time.
I haven't been able to make any progress so deassigning myself. I believe I've done this correctly but please let me know if not (apologies this is my first ticket).

[Antoliny]

Replying to Alex Hatfield:

Hi Antoliny, thanks for the comment - apologies for causing any confusion, will be sure to wait for acceptance next time.
I haven't been able to make any progress so deassigning myself. I believe I've done this correctly but please let me know if not (apologies this is my first ticket).

No worries Alex, thank you for giving this ticket a try!
It’s totally fine to start working before accepted — I just mentioned it because I didn’t want your efforts to go to waste in case it didn’t get accepted.
You’re welcome to pick this up again anytime! (Now that it’s accepted, as long as no one else has taken over!)

[Md. Miftahul Kabir]

Replying to Mridul:
Hello Mridul, can I change the owner to me? I already solved this ticket for my personal practice and I was able to solve the issue. If you think it's okay then I can change the owner status to me and create a pull request.
Thank you

[Mridul]

Hey,
Yes, no problem please feel free to go agead and do that

[Md. Miftahul Kabir]

PR link: ​https://github.com/django/django/pull/19942

[Nilesh Pahari]

Hi! Since this has been open for a while, can I pick it up? I’m new to the codebase and this would be my first contribution.

[Nilesh Pahari]

Hi,
It looks like Md. Miftahul Kabir already fixed the issues and only the tests are needed, should I create a new PR adding tests along with the code written by Md. Miftahul Kabir and mention him?

[Jacob Walls]

Yes, please add co-authored-by in the commit message, check git log for examples or see online tutorials.

[Nilesh Pahari]

PR link: ​https://github.com/django/django/pull/20396