Opened 5 weeks ago

Closed 5 weeks ago

Last modified 2 weeks ago

#36528 closed Bug (fixed)

When "view_on_site" is set to True, the rendered button has an underline.

Reported by: Antoliny Owned by: Antoliny
Component: contrib.admin Version: dev
Severity: Release blocker Keywords: changeform viewonsite
Cc: Antoliny Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description

In this commit(ticket), we added underlines to links to improve accessibility.
However, the "view on site" button in the changeform should not have an underline, but it currently does.
It seems this part was missed in the above commit.


Attachments (1)

Screenshot 2025-07-28 at 8.20.41 AM.png (11.0 KB ) - added by Antoliny 5 weeks ago.

Download all attachments as: .zip

Change History (9)

comment:1 by Natalia Bidart, 5 weeks ago

Keywords: viewonsite added
Severity: NormalRelease blocker
Triage Stage: UnreviewedAccepted
Version: 5.2dev

Thank you Antoliny! I can confirm I get the same underline as reported. Setting this ticket as release blocker for 6.0.

comment:2 by Antoliny, 5 weeks ago

Owner: set to Antoliny
Status: newassigned

comment:3 by Antoliny, 5 weeks ago

Has patch: set

comment:4 by Antoliny, 5 weeks ago

Needs tests: set

comment:5 by Antoliny, 5 weeks ago

Needs tests: unset

comment:6 by Sarah Boyce, 5 weeks ago

Triage Stage: AcceptedReady for checkin

comment:7 by Sarah Boyce <42296566+sarahboyce@…>, 5 weeks ago

Resolution: fixed
Status: assignedclosed

In 792ca148:

Fixed #36528, Refs #34917 -- Removed role="button" from object-tools links.

Regression in 849f8307a5bb33465252d0891a9b2c47dde65889.
In order to prevent underlines on links styled like buttons, role="button" was added.
This has been removed and the style updated to reflect that these are links.

comment:8 by GitHub <noreply@…>, 2 weeks ago

In 3bd583f:

Refs #36528 -- Fixed link underline typo in CSS.

Regression in 792ca148a2d6da6cf0778f6a866c899208ab94f9.

Note: See TracTickets for help on using tickets.
Back to Top