Opened 13 months ago
Last modified 5 days ago
#34917 assigned Cleanup/optimization
Links in the Django admin should be underlined.
Reported by: | Dmitriy Chukhin | Owned by: | Maira Usman |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Normal | Keywords: | accessibility, anchor |
Cc: | Thibaud Colas, Sarah Abderemane, Tom Carrick, Ülgen Sarıkavak | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | yes |
Description (last modified by )
Attachments (2)
Change History (17)
comment:1 by , 13 months ago
Description: | modified (diff) |
---|
by , 13 months ago
Attachment: | Screenshot.png added |
---|
comment:2 by , 13 months ago
Cc: | added |
---|---|
Resolution: | → wontfix |
Status: | assigned → closed |
comment:3 by , 13 months ago
Description: | modified (diff) |
---|
comment:4 by , 13 months ago
Description: | modified (diff) |
---|
by , 12 months ago
Attachment: | django 5.1dev20231027 link styles.png added |
---|
comment:5 by , 12 months ago
Resolution: | wontfix |
---|---|
Status: | closed → new |
@Marius I do not know what discussion you’re referring to in #34038 but the resolution isn’t appropriate. Links need to be clearly identifiable. There needs to be a way to tell the links apart from surrounding text without relying on color. The current styles implemented in the admin are so bad I’d qualify this as a release blocker if the changes were made in the last release.
As a practical example, it is more or less impossible to identify where links are in help text:
As far as this issue about _links within text_, I would recommend:
- A minimum contrast ratio of ideally 4.5:1, at the vey least 3:1 between link text color and text color. Currently we’re somewhere around 1.6:1 to 2.2:1 in the light theme, which is unacceptable.
- And an underline, for people who have severe color blindness.
For links outside text there are more options. I also think the current design choices aren’t fit for purpose but that likely warrants a separate ticket as the resolution could be very different from what makes sense for links within text.
comment:6 by , 12 months ago
Resolution: | → duplicate |
---|---|
Status: | new → closed |
The current styles implemented in the admin are so bad I’d qualify this as a release blocker if the changes were made in the last release.
Why as a release blocker? We can decide that #34038 is not completely fixed without an underline, but 1d0fa848e084cad62d0bb6bde3b51e4862558e57 didn't introduce any regression so it's not a release blocker.
Closing as a duplicate of #34038.
comment:8 by , 9 months ago
Resolution: | duplicate |
---|---|
Status: | closed → new |
Summary: | Links within text in the Django admin are difficult to identify → Links in the Django admin should be underlined. |
Triage Stage: | Unreviewed → Someday/Maybe |
Type: | Bug → Cleanup/optimization |
Reopen for adding underline to links in the admin.
Marking as "Someday/Maybe" pending a discussion by the Accessibility Team to determine the scope of required changes.
comment:9 by , 9 months ago
So we've had a brief discussion and we've agreed that links in the "main content area" should be underlined.
My personal thought on "main content area" is "not the header or nav sidebar".
I think this should ideally exclude the site index and app index pages (they're quite clear), but acceptable if these are underlined as well.
There will probably also be other exceptions such as pagination links and other links that look like buttons, but I think we can tease those out in a review.
comment:10 by , 9 months ago
Has patch: | set |
---|---|
Patch needs improvement: | set |
Triage Stage: | Someday/Maybe → Accepted |
comment:13 by , 8 months ago
Cc: | added |
---|
comment:15 by , 6 months ago
Patch needs improvement: | set |
---|
comment:16 by , 6 months ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
Thanks for the ticket, however, this was discussed as a part of #34038, and at the end removed from the recommendation.