Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#3527 closed (wontfix)

better debug traceback with code executing...

Reported by: Jens Owned by: nobody
Component: Core (Other) Version: master
Severity: Keywords: debug, traceback
Cc: pythonmailing@…, armin.ronacher@…, jshaffer2112@…, django_trac@… Triage Stage: Design decision needed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: UI/UX:

Description

The django debug traceback ist good. But the colubrids one is better:
http://trac.pocoo.org/browser/colubrid/trunk/colubrid/debug.py

With this debug traceback you can execute python code via a small AJAX script. Everything is in the debug.py file from above.

Attachments (3)

django_debugger.patch (17.0 KB) - added by Marek Kubica <pythonmailing@…> 8 years ago.
Patch by Armin Ronacher to add a debugger to Django's exceptions
django_debugger_r5588.diff (13.9 KB) - added by John Shaffer <jshaffer2112@…> 8 years ago.
Patch against [5588]
django_debugger_r5620.diff (13.4 KB) - added by John Shaffer <jshaffer2112@…> 8 years ago.
Patch against [5620]. This one doesn't cause any visual changes.

Download all attachments as: .zip

Change History (20)

comment:1 follow-up: Changed 9 years ago by SmileyChris

  • Needs documentation unset
  • Needs tests unset
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Design decision needed

This isn't a very clearly defined ticket (and code executing sounds dodgy) but I'll leave for someone else to close.

comment:2 in reply to: ↑ 1 Changed 9 years ago by anonymous

Replying to SmileyChris:

(and code executing sounds dodgy)

I forgot. The code executing is naturally only for debugging ;) And this is very, very helpfully!

from the docs http://wsgiarea.pocoo.org/colubrid/documentation/server/#enable-evalexception-feature :
"""
The debugger features a system which lets you execute arbitrary code in exceptions' stack frames, like paste's evalexception. Because this is a potential security risk, you must activate it explicitly with an additional keyword argument:
"""
see also:

comment:3 Changed 8 years ago by mtredinnick

  • Resolution set to wontfix
  • Status changed from new to closed

This looks outside the scope of Django. Building a Python debugger into the web browser looks cool, but dangerous. If somebody wanted to, it would be possible dynamically put this in as the traceback handler in their own Django code fairly easily, I suspect. Anybody who wanted to write up a wiki page on that would be welcome.

comment:4 Changed 8 years ago by anonymous

  • Resolution wontfix deleted
  • Status changed from closed to reopened

I do not understand, why is not for the purposes of django!
It is a big help for debugging.

On the subject Dangerously: This debugger should only work with the built in development Web server. And here stands clear: "DO NOT USE THIS SERVER IN A PRODUCTION SETTING."

So, what it the problem?

comment:5 Changed 8 years ago by Simon G. <dev@…>

  • Resolution set to wontfix
  • Status changed from reopened to closed

Can you please raise this in the django-developers mailing list if you want to debate things. The mailing list is easier for people to beat around ideas/arguments like this.

Thanks,
Simon

Changed 8 years ago by Marek Kubica <pythonmailing@…>

Patch by Armin Ronacher to add a debugger to Django's exceptions

comment:7 Changed 8 years ago by Marek Kubica <pythonmailing@…>

  • Cc pythonmailing@… added
  • Has patch set

comment:8 Changed 8 years ago by anonymous

  • Cc armin.ronacher@… added
  • Resolution wontfix deleted
  • Status changed from closed to reopened

comment:9 follow-up: Changed 8 years ago by Armin Ronacher

Anything new regarding that patch?

comment:10 in reply to: ↑ 9 Changed 8 years ago by mtredinnick

Replying to Armin Ronacher:

Anything new regarding that patch?

Please don't post noise like that. It adds nothing to the ticket. If there was news, you would see it in the comments being updated. As far as I'm concerned, it's still wontfix for the reason given above.

comment:11 Changed 8 years ago by Armin Ronacher

It's just interesting to see that the discussion in the trac is at "wontfix" whereas people in the mailinglist seem to like the idea and there was no real show stopper.

Changed 8 years ago by John Shaffer <jshaffer2112@…>

Patch against [5588]

comment:12 Changed 8 years ago by John Shaffer <jshaffer2112@…>

  • Cc jshaffer2112@… added

comment:13 Changed 8 years ago by Jens Diemer

  • Cc django_trac@… added

Changed 8 years ago by John Shaffer <jshaffer2112@…>

Patch against [5620]. This one doesn't cause any visual changes.

comment:14 follow-up: Changed 8 years ago by Simon G. <dev@…>

  • Resolution set to wontfix
  • Status changed from reopened to closed

Wontfix. Again. I'm not sure that anyone is convinced that this is a good idea. Please raise this on django-developers to discuss.

comment:15 Changed 8 years ago by Simon G. <dev@…>

To have any chance of being implemented this will need to be a middleware or something pluggable, and not part of the core debug page. Please feel free to rewrite it as such.

comment:16 in reply to: ↑ 14 Changed 8 years ago by anonymous

Replying to Simon G. <dev@simon.net.nz>:

Wontfix. Again. I'm not sure that anyone is convinced that this is a good idea. Please raise this on django-developers to discuss.

There was a discuss here: http://groups.google.com/group/django-developers/browse_thread/thread/cca45aa7c9106b88

I think is would be a nice idea to make this as a middleware on the Sprint. So adding this idea on the SprintIdeas page???

comment:17 Changed 8 years ago by Michael Radziej <mir@…>

The core developers are not interested in this, and the decision is final. If you can put it into a separate middleware, please put it into the django snippets site and anybody interested can use it from there. I personally lile it, but the security implications are too serious to make it part of the project.

Note: See TracTickets for help on using tickets.
Back to Top