Opened 11 months ago
Closed 11 months ago
#35112 closed Cleanup/optimization (fixed)
Confusing animation of admin date picker buttons
Reported by: | Alexander Lazarević | Owned by: | Alexander Lazarević |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Tom Carrick, elky | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | yes |
Description (last modified by )
In the admin date picker widget there are two buttons to go to the previous month (<) and to the next month (>). While hovering the mouse over it they do some "scroll up" animation.
- I don't think the animation is any helpful to indicate that you are hovering with the mouse over the button. A colour highlight of some sort would be more helpful.
- The animation is for some reason not consistent. When you pressed the previous month button once, leave the button and hover over it again, the animation is not shown. If you hover over the next month button, the animation is shown. This is confusing and not helpful at all.
I've attached a short video that hopefully better shows the issue.
This was performed with Firefox 121.0.1
The admin date picker overall looks dated (no pun intended) and lacks functions that are now commonly expected, like a way to select the month or the year directly. There is already a ticket for that #9388
Attachments (1)
Change History (11)
by , 11 months ago
Attachment: | Screencast_15_01_24_12:00:19.mp4 added |
---|
comment:1 by , 11 months ago
Description: | modified (diff) |
---|
comment:2 by , 11 months ago
Cc: | added |
---|---|
Triage Stage: | Unreviewed → Accepted |
I agree that this animation is unnecessary.
comment:3 by , 11 months ago
I agree, it looks more glitchy than helpful.
I also agree that the datepicker is dated, but it also has a lot of other problems.The accessibility team has discussed the date picker multiple times but so far there's no clear alternative we can get people to agree on. I'm loosely in favour of removing our widgets and using the native browser controls, but there are problems with these at the moment as well.
comment:4 by , 11 months ago
I guess it is just a matter of removing this two entries in the CSS:
.calendarbox .calendarnav-previous:focus, .calendarbox .calendarnav-previous:hover { background-position: 0 -15px; } ... .calendarbox .calendarnav-next:focus, .calendarbox .calendarnav-next:hover { background-position: 0 -45px;
The calendar-icons.svg
could be changed as well to only contain the two used icons.
comment:5 by , 11 months ago
Alexander, feel free to make a PR, otherwise I will get to it in the coming days.
comment:6 by , 11 months ago
Owner: | changed from | to
---|---|
Status: | new → assigned |
comment:7 by , 11 months ago
Has patch: | set |
---|
I created a PR https://github.com/django/django/pull/17737
comment:8 by , 11 months ago
Patch needs improvement: | set |
---|
comment:9 by , 11 months ago
Patch needs improvement: | unset |
---|---|
Triage Stage: | Accepted → Ready for checkin |
Screencast of the previous month (<) and next month (>) buttons