Opened 8 years ago

Last modified 2 years ago

#9388 assigned New feature

Year navigation in admin's date widgets' calendar

Reported by: Fidel Ramos Owned by: Javier de la Rosa
Component: contrib.admin Version: master
Severity: Normal Keywords: admin calendar year previous next widget ui
Cc: versae@…, danny.adair@…, idan@… Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: yes

Description

My colleague Javier de la Rosa has enhanced the calendar shown in admin's date fields to allow navigation through years, and not only through months. This requires changing calendar.js and DateTimeShortcuts.js.

We have chosen not to maintain backwards compatibility because this should be a feature in Django 1.1, but it's easy to do if required.

Javier de la Rosa will attach his patch later.

Attachments (3)

year_navigation_in_calendar_r9232.diff (4.6 KB) - added by Javier de la Rosa 8 years ago.
Patch for django trunk r9232
9833-r12089.diff (3.0 KB) - added by Ramiro Morales 7 years ago.
patch updated to apply cleanly to trunk as of r12089.
9388-r16225.diff (3.0 KB) - added by Ramiro Morales 5 years ago.
Patch updated to r16225

Download all attachments as: .zip

Change History (18)

Changed 8 years ago by Javier de la Rosa

Patch for django trunk r9232

comment:1 Changed 8 years ago by Javier de la Rosa

Cc: versae@… added; jrosa@… removed
Component: Contrib appsdjango.contrib.admin
Has patch: set
Needs documentation: unset
Needs tests: unset
Owner: changed from nobody to Javier de la Rosa
Patch needs improvement: unset
Status: newassigned

Patch added.
If backwards compatibility is required, I can send a new patch with the proposal, it's done but I chose not to include it.

comment:2 Changed 8 years ago by (none)

milestone: post-1.0

Milestone post-1.0 deleted

comment:3 Changed 8 years ago by Jacob

Triage Stage: UnreviewedDesign decision needed

Changed 7 years ago by Ramiro Morales

Attachment: 9833-r12089.diff added

patch updated to apply cleanly to trunk as of r12089.

comment:4 Changed 7 years ago by Ramiro Morales

Keywords: admin calendar year previous next widget added

Patch has been updated to current trunk status. Modified to keep current element class names for month navigation unmodified and add brand new "-year"-suffixed names for elements involved in year navigation. This is what interpret is what the OP was talking about when he said 'backward compatibility'.

(Wrong ticket number in patch file name is a typo.)

comment:5 Changed 7 years ago by Ramiro Morales

See also #2889 that proposed the same thing.

comment:6 Changed 7 years ago by Ramiro Morales

#6487 proposed the same and also contains a patch.

comment:7 Changed 7 years ago by Tay Ray Chuan

ramiro: I closed the tickets you referenced as related; that way, we can focus out attention of this ticket.

comment:8 Changed 6 years ago by anonymous

Cc: danny.adair@… added

comment:9 Changed 5 years ago by Luke Plant

Severity: Normal
Type: New feature

Changed 5 years ago by Ramiro Morales

Attachment: 9388-r16225.diff added

Patch updated to r16225

comment:10 Changed 5 years ago by Idan Gazit

Cc: idan@… added
Easy pickings: unset

comment:11 Changed 5 years ago by Idan Gazit

Keywords: ui added

comment:12 Changed 5 years ago by Idan Gazit

UI/UX: set

comment:13 Changed 5 years ago by lawgon@…

I tried this patch on the latest trunk (had to do it manually as the directory structure has changed.) Nothing happened, the widget is unchanged.

comment:14 Changed 4 years ago by Aymeric Augustin

Triage Stage: Design decision neededAccepted

This sounds useful, I don't know which design decision was expected.

comment:15 Changed 2 years ago by Tomek Paczkowski

Patch needs improvement: set

Unfortunately, patch no longer applies.

Note: See TracTickets for help on using tickets.
Back to Top