Opened 15 months ago
Last modified 11 months ago
#34981 assigned New feature
Promote `--pair` and `--bisect` from `runtest.py` to be available as flags for the Django `test` command
Reported by: | Natalia Bidart | Owned by: | Sulabh Katila |
---|---|---|---|
Component: | Testing framework | Version: | dev |
Severity: | Normal | Keywords: | |
Cc: | Adam Johnson | Triage Stage: | Accepted |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | yes |
Easy pickings: | no | UI/UX: | no |
Pull Requests: | |||
Description ¶
Following a recent conversation in the forum, it was suggested that we promote the flags --pair
and --bisect
to be available in the Django test
command. Currently these are only implemented in the Django custom runtests.py
helper script.
According to the ticket's flags, the next step(s) to move this issue forward are:
- To improve the patch as described in the pull request review comments or on this ticket, then uncheck "Patch needs improvement".
If creating a new pull request, include a link to the pull request in the ticket comment when making that update. The usual format is:
[https://github.com/django/django/pull/#### PR]
.
Change History (12)
comment:1 by , 15 months ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:3 by , 15 months ago
Easy pickings: | unset |
---|---|
Type: | Uncategorized → New feature |
Looking at how intertwined the code for these options is with other code in runtests.py
(even hardcoding certain Django tests apps), I doubt this is "easy pickings."
comment:5 by , 15 months ago
Owner: | set to |
---|---|
Status: | new → assigned |
comment:6 by , 14 months ago
Cc: | added |
---|
comment:7 by , 14 months ago
Has patch: | set |
---|
comment:8 by , 14 months ago
Patch needs improvement: | set |
---|
comment:9 by , 14 months ago
Patch needs improvement: | unset |
---|
comment:10 by , 14 months ago
Needs documentation: | set |
---|---|
Needs tests: | set |
Patch needs improvement: | set |
Hi Sulabh, tests and documentation are also required. Ideally, we wouldn't duplicate all the similar code in runtests.py
as well.
Also, I didn't test it much, but when I tried --pair
with the tutorial project, I see "Check test pairing with unittest.loader" which seems like a bug.
comment:11 by , 13 months ago
Hi Tim, I have made some changes and added the tests and documentation. I tested it with a sample project, and it seems to be working now.
comment:12 by , 13 months ago
Patch needs improvement: | unset |
---|
comment:13 by , 12 months ago
Needs documentation: | unset |
---|---|
Needs tests: | unset |
comment:14 by , 11 months ago
Patch needs improvement: | set |
---|
Makes sense!