Opened 17 months ago
Closed 17 months ago
#34656 closed Bug (fixed)
Wrong HTML generation in Django admin's change_password form
Reported by: | Yaser Amiri | Owned by: | Yaser Amiri |
---|---|---|---|
Component: | contrib.admin | Version: | 4.2 |
Severity: | Normal | Keywords: | |
Cc: | David Smith | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | yes |
Description
Context: contrib.admin package
In auth/user/change_password.html
there is a condition that checks existence of id_for_label for password1 field, the {% endif %}
is closed in the wrong position and if the condition return False, the HTML will be corrupted (I'm not sure if it's possible to make the condition falsy)
Change History (5)
comment:1 by , 17 months ago
Cc: | added |
---|---|
Easy pickings: | set |
Triage Stage: | Unreviewed → Accepted |
comment:2 by , 17 months ago
Owner: | changed from | to
---|
comment:4 by , 17 months ago
Needs tests: | unset |
---|---|
Triage Stage: | Accepted → Ready for checkin |
Note:
See TracTickets
for help on using tickets.
Thanks for the report. Regression in 6991880109e35c879b71b7d9d9c154baeec12b89.
Would you like to prepare a patch?