Tests for RadioSelect and Select have diverged considerably, potentially leaving RadioSelect undertested
Even though Select and RadioSelect both share most of the functionality by inheriting from ChoiceWidget, there are no explicit tests for ChoiceWidget, and tests for Select and RadioSelect have diverged considerably over time.
While some tests will be specific to each children (for their custom code), after inspection when reviewing PR for #34034, there seems to be some tests that were added to Select but not added to their counterpart RadioSelect, for example test_deepcopy.
My hope with this ticket is to either:
- evaluate the creation of specific tests for
ChoiceWidget and have tests for Select and RadioSelect reusing those, and then having custom tests for their custom functionality
- extend the tests for
RadioSelect using those for Select as a guide and have some sort of comment suggesting to grow both test suites when making changes to their parent class.
Change History
(8)
| Triage Stage: |
Unreviewed → Accepted
|
| Owner: |
changed from nobody to Jacob1507
|
| Status: |
new → assigned
|
| Has patch: |
set
|
| Patch needs improvement: |
set
|
| Owner: |
changed from Jacob1507 to Faishal Manzar
|
| Owner: |
changed from Faishal Manzar to Jacob1507
|
| Patch needs improvement: |
unset
|
| Resolution: |
→ fixed
|
| Status: |
assigned → closed
|
| Triage Stage: |
Accepted → Ready for checkin
|
For the future, extra test coverage is always welcome, no ticket required.