Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#34049 closed Bug (fixed)

Admin - Scrollbar appears without overflowing content

Reported by: Durieux Owned by: Durieux
Component: contrib.admin Version: dev
Severity: Release blocker Keywords:
Cc: Thibaud Colas Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: yes

Description (last modified by Durieux)

A scrollbar appears on the admin pages even if content is smaller than the viewport.

This behavior is caused by an invisible SVG file used for the night mode toggle sprite.
The SVG image is taking some space in the bottom of the page.

Adding a CSS rule to add display: none to the element appears to solve the issue.

Link to the PR: ​https://github.com/django/django/pull/16109

Change History (6)

comment:1 by Durieux, 3 years ago

Description: modified (diff)
Has patch: set

comment:2 by Mariusz Felisiak, 3 years ago

Triage Stage: Unreviewed → Accepted

Good catch!

Regression in bc7aa2a5e91cf65fc7510edaf1776528c7ad07b4.

comment:3 by Mariusz Felisiak, 3 years ago

Triage Stage: Accepted → Ready for checkin

comment:4 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

Resolution: → fixed
Status: assigned → closed

In 2905cbfd:

Fixed #34049 -- Fixed displaying SVGs patterns.

Regression in bc7aa2a5e91cf65fc7510edaf1776528c7ad07b4.

comment:5 by Claude Paroz, 3 years ago

I wonder if we should start using the hidden attribute instead of the display: none; CSS directive.

in reply to:  5 comment:6 by Mariusz Felisiak, 3 years ago

Replying to Claude Paroz:

I wonder if we should start using the hidden attribute instead of the display: none; CSS directive.

As far as I'm aware ​it depends where we would like to use it, but in this case hidden fits perfectly.

Note: See TracTickets for help on using tickets.
Back to Top