#34049 closed Bug (fixed)
Admin - Scrollbar appears without overflowing content
Reported by: | Durieux | Owned by: | Durieux |
---|---|---|---|
Component: | contrib.admin | Version: | dev |
Severity: | Release blocker | Keywords: | |
Cc: | Thibaud Colas | Triage Stage: | Ready for checkin |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | yes | UI/UX: | yes |
Description (last modified by )
A scrollbar appears on the admin pages even if content is smaller than the viewport.
This behavior is caused by an invisible SVG file used for the night mode toggle sprite.
The SVG image is taking some space in the bottom of the page.
Adding a CSS rule to add display: none
to the element appears to solve the issue.
Link to the PR: https://github.com/django/django/pull/16109
Change History (6)
comment:1 by , 2 years ago
Description: | modified (diff) |
---|---|
Has patch: | set |
comment:2 by , 2 years ago
Triage Stage: | Unreviewed → Accepted |
---|
comment:3 by , 2 years ago
Triage Stage: | Accepted → Ready for checkin |
---|
follow-up: 6 comment:5 by , 2 years ago
I wonder if we should start using the hidden
attribute instead of the display: none;
CSS directive.
comment:6 by , 2 years ago
Replying to Claude Paroz:
I wonder if we should start using the
hidden
attribute instead of thedisplay: none;
CSS directive.
As far as I'm aware it depends where we would like to use it, but in this case hidden
fits perfectly.
Good catch!
Regression in bc7aa2a5e91cf65fc7510edaf1776528c7ad07b4.