Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#33486 closed Cleanup/optimization (wontfix)

Allow translations' variants based on objects count for admin's delete selected confirmation messages

Reported by: Maciej Olko Owned by: Maciej Olko
Component: contrib.admin Version: dev
Severity: Normal Keywords: i18n, gettext, ngettext
Cc: Carlton Gibson Triage Stage: Unreviewed
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description

Admin's delete selected confirmation messages can contain singular and plural form of a model name as objects_name inside the message.

Despite the fact that for English those messages are the same for singular and plural count, in Polish (and potentially other languages) we inflect adjectives and pronoun basing on the count.

Bringing the pluralization to those three messages will allow to simplify the translations, which now for Polish list all alternative endings (to be done on Transifex).

Change History (5)

comment:1 by Maciej Olko, 3 years ago

As an example one of those three messages:

Deleting the selected %(objects_name)s would require deleting the following protected related objects:

Current Polish translation:

Usunięcie wybranych(-nego)(-nej) %(objects_name)s wymaga skasowania następujących chronionych obiektów, które są z nim(i)/nią powiązane:

After having it divided into two messages, for count=1 it would be:

Usunięcie wybranej(-nego) %(objects_name)s wymaga skasowania następujących chronionych obiektów, które są z nią/nim powiązane:

And for many:

Usunięcie wybranych %(objects_name)s wymaga skasowania następujących chronionych obiektów, które są z nimi powiązane:

comment:2 by Maciej Olko, 3 years ago

Summary: Admin's delete selected confirmation messages should allow translations variants based on objects countAllow translations' variants based on objects count for admin's delete selected confirmation messages

comment:3 by Mariusz Felisiak, 3 years ago

Cc: Carlton Gibson added
Resolution: wontfix
Status: assignedclosed

As far as I'm aware:

"Usunięcie wybranych %(objects_name)s wymaga skasowania następujących chronionych obiektów, które są z nimi powiązane:"

sounds good with both single and multiple objects. It is also linguistically acceptable. I see no reason to complicate it unnecessarily.

comment:4 by Maciej Olko, 3 years ago

Hi Mariusz, thank you for your response.

Please note that %(objects_name)s will be replaced by model name in plural or singular form, that is e.g. "użytkownik" and "użytkownicy" depending of the count (in English it's "user" and "users"). (Either way also inflection of the noun here is in a wrong grammatical case, but I'm not trying to improve that here.)

The alternative endings of words are compatible with the answer by Adam Wolański in PWN language counseling [1].

[1] https://sjp.pwn.pl/poradnia/haslo/Alternatywne-formy-meskie-i-zenskie;17609.html

in reply to:  4 comment:5 by Mariusz Felisiak, 3 years ago

Replying to Maciej Olko:

Hi Mariusz, thank you for your response.

Please note that %(objects_name)s will be replaced by model name in plural or singular form, that is e.g. "użytkownik" and "użytkownicy" depending of the count (in English it's "user" and "users"). (Either way also inflection of the noun here is in a wrong grammatical case, but I'm not trying to improve that here.)

The alternative endings of words are compatible with the answer by Adam Wolański in PWN language counseling [1].

[1] https://sjp.pwn.pl/poradnia/haslo/Alternatywne-formy-meskie-i-zenskie;17609.html

Yes, but adding new variants would not help a lot if we consider objects_name, we'd get:

"Usunięcie wybranej(-nego) użytkownik wymaga skasowania następujących chronionych obiektów, które są z nią/nim powiązane:"
"Usunięcie wybranych użytkownicy wymaga skasowania następujących chronionych obiektów, które są z nimi powiązane:"

Note: See TracTickets for help on using tickets.
Back to Top