Code

Opened 7 years ago

Closed 16 months ago

#3343 closed Bug (wontfix)

Doctest find() doesn't work for model subpackage (models/__init__.py)

Reported by: anonymous Owned by: nobody
Component: Testing framework Version: master
Severity: Normal Keywords:
Cc: noah@…, jesse.lovelace@… Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

#2982 addresses a small issue with splitting up models into a subpackage. This works fine, except the test runner can no longer find doctests in the other package files.

This is the default doctest behavior, to avoid recursing too far on packages. I have found that removing the module filter works just fine on all my model subpackages, but I am not sure if there are other consequences of removing this...

Maybe there is a better way to address this issue?

Attachments (1)

doctest_module_package.patch (555 bytes) - added by noah@… 7 years ago.

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by noah@…

comment:1 Changed 7 years ago by Simon G. <dev@…>

  • Component changed from Uncategorized to Unit test system
  • Needs documentation unset
  • Needs tests unset
  • Owner changed from jacob to adrian
  • Patch needs improvement unset
  • Triage Stage changed from Unreviewed to Accepted

comment:2 Changed 7 years ago by anonymous

  • Cc jesse.lovelace@… added

comment:3 Changed 7 years ago by ubernostrum

This needs to wait for a resolution to #3591.

comment:4 Changed 7 years ago by akaihola

There's a more complicated patch for this in #5751.

I didn't try this, but your approach might drop file/linenum information from error messages.

comment:5 Changed 3 years ago by lrekucki

  • Severity set to Normal
  • Type set to Bug

comment:6 Changed 2 years ago by aaugustin

  • UI/UX unset

Change UI/UX from NULL to False.

comment:7 Changed 2 years ago by aaugustin

  • Easy pickings unset

Change Easy pickings from NULL to False.

comment:8 Changed 16 months ago by aaugustin

  • Resolution set to wontfix
  • Status changed from new to closed

Time has passed since this ticket was accepted, and it no longer looks like a good idea. The trend is to remove custom support for doctests, not to extend it. See #18727 for more details.

Add Comment

Modify Ticket

Change Properties
<Author field>
Action
as closed
as The resolution will be set. Next status will be 'closed'
The resolution will be deleted. Next status will be 'new'
Author


E-mail address and user name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.