Opened 3 years ago

Closed 3 years ago

#33310 closed Cleanup/optimization (fixed)

Remove unused "actions.selected" CSS class.

Reported by: Álvaro Pelegrina Fernández Owned by: Álvaro Pelegrina Fernández
Component: contrib.admin Version: 3.2
Severity: Normal Keywords:
Cc: Carlton Gibson Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

Hello,

First of all I am not sure if this is intended, it's a change happening on Django 3.2

On Django 3.1 this was the admin styling on Select All

https://i.imgur.com/hvIRkis.png

And on Django 3.2 it looks like this:

https://i.imgur.com/DyiY43M.png

Is it intended? Javascript doesnt add anymore the "selected" class and even if you add it manually it doesnt apply the yellow color because the CSS class just apply the body background color.

If it's intended I think we can refactor and just remove this CSS code at changelist.css (and maybe in other places) because it's indeed (as the comment says) not used and its a bit confusing when overriding it for django admin template overriding purposes.

https://github.com/django/django/blob/main/django/contrib/admin/static/admin/css/changelists.css#L299

Change History (6)

comment:1 by Mariusz Felisiak, 3 years ago

Cc: Carlton Gibson added
Summary: Django admin Select All CSS seems inconsistent on latest 3.2.9 versionRemove unused "actions.selected" CSS class.
Triage Stage: UnreviewedAccepted

Thanks for the report, we noticed this change when fixing #33083. I think now it looks better, feel-free to removed unused CSS class.

comment:2 by Mariusz Felisiak, 3 years ago

The same can be removed from responsive.css.

comment:3 by Álvaro Pelegrina Fernández, 3 years ago

Owner: changed from nobody to Álvaro Pelegrina Fernández
Status: newassigned

comment:4 by Álvaro Pelegrina Fernández, 3 years ago

Has patch: set

comment:5 by Álvaro Pelegrina Fernández, 3 years ago

Great, I patches those css files.

This is it's related PR https://github.com/django/django/pull/15117

comment:6 by GitHub <noreply@…>, 3 years ago

Resolution: fixed
Status: assignedclosed

In 98352ddf:

Fixed #33310 -- Removed unused rule from admin CSS.

Unused since 30e59705fc3e3e9e8370b965af794ad6173bf92b.

Note: See TracTickets for help on using tickets.
Back to Top