Opened 10 months ago

Closed 9 months ago

Last modified 9 months ago

#33083 closed Bug (fixed)

"Select All" in admin changelist does not work when both action_on_bottom and actions_on_top are True.

Reported by: Benjamin Locher Owned by: Carlton Gibson
Component: contrib.admin Version: 3.2
Severity: Release blocker Keywords: actions_on_bottom, change_list, admin, actions, admin_actions, select_across, ModelAdmin,
Cc: Jon Dufresne, Carlton Gibson Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

For a Model Admin that has actions_on_bottom set to True:

  • Navigate to a changelist in the Django Admin
  • Select any filters so that there is more than 1 page of results
  • Click the "Select All" checkbox
  • Click "Select all x x" link
  • The field <input type="hidden" name="select_across" value="0" class="select-across"> does not get set to 1 (remains at value=0)
  • Any action selected from the actions list is only performed on the first page of results rather than all the selected items

This bug appears to have begun in 3.2

Change History (6)

comment:1 Changed 10 months ago by Mariusz Felisiak

Cc: Jon Dufresne Carlton Gibson added
Severity: NormalRelease blocker
Summary: Clicking Select All in an admin change_list does not set `select_across` when `action_on_bottom` = True in ModelAdmin"Select All" in admin changelist does not work when both action_on_bottom and actions_on_top are True.
Triage Stage: UnreviewedAccepted

Thanks for the report!

Regression in 30e59705fc3e3e9e8370b965af794ad6173bf92b.

comment:2 Changed 10 months ago by Carlton Gibson

Owner: changed from nobody to Carlton Gibson
Status: newassigned

comment:3 Changed 9 months ago by Carlton Gibson

Has patch: set

comment:4 Changed 9 months ago by GitHub <noreply@…>

Resolution: fixed
Status: assignedclosed

In b0ed6193:

Fixed #33083 -- Fixed selecting all items in the admin changelist when actions are both top and bottom.

Thanks Benjamin Locher for the report.

Regression in 30e59705fc3e3e9e8370b965af794ad6173bf92b.

comment:5 Changed 9 months ago by Mariusz Felisiak <felisiak.mariusz@…>

In 8467c4e:

[4.0.x] Fixed #33083 -- Fixed selecting all items in the admin changelist when actions are both top and bottom.

Thanks Benjamin Locher for the report.

Regression in 30e59705fc3e3e9e8370b965af794ad6173bf92b.
Backport of b0ed619303d2fb723330ca9efa3acf23d49f1d19 from main

comment:6 Changed 9 months ago by Mariusz Felisiak <felisiak.mariusz@…>

In 6760f4fa:

[3.2.x] Fixed #33083 -- Fixed selecting all items in the admin changelist when actions are both top and bottom.

Thanks Benjamin Locher for the report.

Regression in 30e59705fc3e3e9e8370b965af794ad6173bf92b.
Backport of b0ed619303d2fb723330ca9efa3acf23d49f1d19 from main

Note: See TracTickets for help on using tickets.
Back to Top