Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#33030 closed Cleanup/optimization (fixed)

Broken gdal.org URLs in django.contrib.gis.gdal, docs.ref.contrib.gis and gis_tests

Reported by: MaertHaekkinen Owned by: MaertHaekkinen
Component: GIS Version: 3.2
Severity: Normal Keywords: broken link url tutorial tests gdal
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description (last modified by MaertHaekkinen)

There are multiple broken URLs directing to various pages on *https://gdal.org.
In addition to the links that result in 404, I have highlighted various links which could be written without the additional '.html' suffix. It's not needed by gdal.org

The pull request for said issue can be found here: https://github.com/django/django/pull/14778

The URLs in question, can be found here :
*https://github.com/django/django/blob/main/django/contrib/gis/gdal/driver.py#L13
*https://github.com/django/django/blob/main/django/contrib/gis/gdal/driver.py#L18
*https://github.com/django/django/blob/main/django/contrib/gis/gdal/driver.py#L19

*https://github.com/django/django/blob/main/django/contrib/gis/gdal/envelope.py#L20
*https://github.com/django/django/blob/main/django/contrib/gis/gdal/error.py#L32
*https://github.com/django/django/blob/main/django/contrib/gis/gdal/feature.py#L10
*https://github.com/django/django/blob/main/django/contrib/gis/gdal/field.py#L11
*https://github.com/django/django/blob/main/django/contrib/gis/gdal/geometries.py#L3
*https://github.com/django/django/blob/main/django/contrib/gis/gdal/geometries.py#L4
*https://github.com/django/django/blob/main/django/contrib/gis/gdal/geometries.py#L56
*https://github.com/django/django/blob/main/django/contrib/gis/gdal/layer.py#L18
*https://github.com/django/django/blob/main/django/contrib/gis/gdal/prototypes/raster.py#L98
*https://github.com/django/django/blob/main/django/contrib/gis/gdal/raster/const.py#L8
*https://github.com/django/django/blob/main/django/contrib/gis/gdal/raster/const.py#L47

*https://github.com/django/django/blob/main/docs/ref/contrib/gis/gdal.txt#L453
*https://github.com/django/django/blob/main/docs/ref/contrib/gis/tutorial.txt#L305

*https://github.com/django/django/blob/main/tests/gis_tests/inspectapp/tests.py#L194

Change History (12)

comment:1 by MaertHaekkinen, 3 years ago

Description: modified (diff)

comment:2 by MaertHaekkinen, 3 years ago

Description: modified (diff)

comment:3 by MaertHaekkinen, 3 years ago

Keywords: broken link url tutorial tests gdal added; links 404 gis GDAL removed

comment:4 by MaertHaekkinen, 3 years ago

Summary: Broken gdal.org URLs in django.contrib.gis.gdal and docs.ref.contrib.gis and gis_testsBroken gdal.org URLs in django.contrib.gis.gdal, docs.ref.contrib.gis and gis_tests

comment:5 by Carlton Gibson, 3 years ago

Triage Stage: UnreviewedAccepted

Super. Thanks for the report. Fancy making a PR? 👍

in reply to:  5 comment:6 by MaertHaekkinen, 3 years ago

Has patch: set

Replying to Carlton Gibson:

Super. Thanks for the report. Fancy making a PR? 👍

Yes, added PR

Last edited 3 years ago by MaertHaekkinen (previous) (diff)

comment:7 by MaertHaekkinen, 3 years ago

Description: modified (diff)

comment:8 by MaertHaekkinen, 3 years ago

Description: modified (diff)

comment:9 by Mariusz Felisiak, 3 years ago

Patch needs improvement: set

comment:10 by Mariusz Felisiak, 3 years ago

Patch needs improvement: unset
Triage Stage: AcceptedReady for checkin

comment:11 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

Resolution: fixed
Status: assignedclosed

In ed317e79:

Fixed #33030 -- Fixed broken links to GDAL docs.

comment:12 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

In 358e65a5:

[3.2.x] Fixed #33030 -- Fixed broken links to GDAL docs.

Backport of ed317e79e355bd3aacb1393b821df7b1a7267ebc from main

Note: See TracTickets for help on using tickets.
Back to Top