Can't open multiple Django Admin Popups for the same related field.

[Yash Jhunjhunwala]

Django Admin shows popup for adding/editing a related field object. The popup doesn't always a new popup but instead replaces the current one when opening multiple popups.

Steps to recreate the problem:

For E.g.

class A(models.Model):
    foo = models.ForeignKey('self', on_delete=models.SET_NULL,null=True,blank=True,verbose_name="If True",related_name="foo_set",)
    bar = models.ForeignKey('self', on_delete=models.SET_NULL,null=True,blank=True,verbose_name="If True",related_name="bar_set",)

For the above Model A :

Create a new instance of model A using the admin. Open a relatedmodel popup for foo by clicking on the add sign.
In the new pop up click on the add sign for foo again and it will replace the current popup (instead of opening up another popup) whereas if you click on the add sign for bar it will open another popup - which is the expected behavior.

[Carlton Gibson]

Hi. Thanks for the report.

I'm going to say wontfix here.

In the normal case this works as expected. I'm adding a new object for a foreign key; I click the same + button; I can't add two objects to the same FK, so the popup is replaced; meanwhile, if I click the + for a second related field a new popup is created (since I can add two different objects to two different FKs).

The case for self is more complex, since in principle I could add a chain of models for the same FK, but each on a different instance. However, without a candidate implementation it's not clear it's worth additional complexity to the popup implementation to handle that case. (You can simply build the chain in the other direction.)

Happy to reopen if you want to work on an implementation that's not too complex though!
Thanks.

[Yash Jhunjhunwala]

Replying to Carlton Gibson:

Happy to reopen if you want to work on an implementation that's not too complex though!

What if we add an index of sorts to the window name. for e.g. if the field name is foo then the instead of window name being "id_foo", we can use "id_foo_1". Also pass the index to popup.

I click the same + button; I can't add two objects to the same FK, so the popup is replaced;

This would work as is since the + will always open window of the same index. But would solve the problem for the chain of models.

[Yash Jhunjhunwala]

Created a draft pull request ​https://github.com/django/django/pull/14823

Need to add tests.

[Carlton Gibson]

Hi Yash. OK — the draft PR looks small enough to consider. I didn't yet check that it functions fully as expected but if that's all that it would take...

Need to add tests.

So for these you'll need to use Selenium. See the section in the contributing guide on ​running the selenium tests.

If you create an admin for a self referential model and check with a test case that a chain (say 3?) can be opened and filled in in order, and that they correctly function (and populate the right form back up the chain) then that shouldn't be too far off.

Thanks.

[Yash Jhunjhunwala]

Added the tests and submitted a new pull request

[Yash Jhunjhunwala]

Fixed Pre Commit Linter issues

[Yash Jhunjhunwala]

Replying to Mariusz Felisiak:
Running pre-commit shows all tests passed but linter workflow fails (isort) on GitHub

[Carlton Gibson]

Just some small tweaks to the behaviour and tests still needed. But patch look sound generally.

[Yash Jhunjhunwala]

Updated the patch as per the changes suggested by Carlton Gibson

[Carlton Gibson <carlton.gibson@…>]

In 492ed60:

Fixed #33029 -- Allowed multiple popups for self-related fields in admin.

[Carlton Gibson <carlton@…>]

In 402ae378:

Refs #33029 -- Fixed popups Selenium tests in headless mode.

Co-authored-by: Yash Jhunjhunwala <yash@…>