Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#33029 closed New feature (fixed)

Can't open multiple Django Admin Popups for the same related field. — at Version 1

Reported by: Yash Jhunjhunwala Owned by: nobody
Component: contrib.admin Version: 3.2
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: yes

Description (last modified by Carlton Gibson)

Django Admin shows popup for adding/editing a related field object. The popup doesn't always a new popup but instead replaces the current one when opening multiple popups.

Steps to recreate the problem:

For E.g.

class A(models.Model):
    foo = models.ForeignKey('self', on_delete=models.SET_NULL,null=True,blank=True,verbose_name="If True",related_name="foo_set",)
    bar = models.ForeignKey('self', on_delete=models.SET_NULL,null=True,blank=True,verbose_name="If True",related_name="bar_set",)

For the above Model A :

Create a new instance of model A using the admin. Open a relatedmodel popup for foo by clicking on the add sign.
In the new pop up click on the add sign for foo again and it will replace the current popup (instead of opening up another popup) whereas if you click on the add sign for bar it will open another popup - which is the expected behavior.

Change History (1)

comment:1 by Carlton Gibson, 3 years ago

Description: modified (diff)
Resolution: wontfix
Status: newclosed
Summary: Django Admin PopupCan't open multiple Django Admin Popups for the same related field.

Hi. Thanks for the report.

I'm going to say wontfix here.

In the normal case this works as expected. I'm adding a new object for a foreign key; I click the same + button; I can't add two objects to the same FK, so the popup is replaced; meanwhile, if I click the + for a second related field a new popup is created (since I can add two different objects to two different FKs).

The case for self is more complex, since in principle I could add a chain of models for the same FK, but each on a different instance. However, without a candidate implementation it's not clear it's worth additional complexity to the popup implementation to handle that case. (You can simply build the chain in the other direction.)

Happy to reopen if you want to work on an implementation that's not too complex though!
Thanks.

Note: See TracTickets for help on using tickets.
Back to Top