Opened 18 years ago
Closed 17 years ago
#3295 closed enhancement (wontfix)
[patch] newforms: I'd like to have a group functionality in forms
Reported by: | ivan | Owned by: | nobody |
---|---|---|---|
Component: | Forms | Version: | |
Severity: | normal | Keywords: | |
Cc: | Triage Stage: | Design decision needed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description (last modified by )
I use my custom group fields in my class forms.
I set an attribute in my form class:
class myform(forms): field1 = ... field2 = ... group_myfields = ['field1','field2']
field1
and field2
are fields sets in my custom form class.
I can retrive html output, writing this:
myform().myfields.as_p() myform().myfields.as_table()
and retrive only fileds listed in group_myfields
.
Attachments (2)
Change History (7)
by , 18 years ago
Attachment: | forms.diff added |
---|
comment:1 by , 18 years ago
Summary: | I'd like to have a group functionality in forms. → [patch] newforms: I'd like to have a group functionality in forms |
---|
by , 18 years ago
Attachment: | groups_in_forms.patch added |
---|
comment:2 by , 18 years ago
I just created a patch using svn diff for easier review by others...
The code seems to be working - all tests pass and it doesn't interfere with rest of the code. On the other hand I feel like more work needs to be done on this - its not systematic and rather hackish...
comment:3 by , 18 years ago
Triage Stage: | Unreviewed → Design decision needed |
---|
I'm not sure whether this functionality is worth adding...
comment:5 by , 17 years ago
Resolution: | → wontfix |
---|---|
Status: | new → closed |
There's really no reason to add this as a built-in -- it's easy to do yourself:
class MyForm(Form): field1 = ... field2 = ... @property def mygroup(self): return {'field1': self.field1, 'field2': self.field2}
This gets you the same {{ form.mygroup.field1 }}
behavior you're looking for. It could be further abstracted out into an abstract Form subclass if you need to do this often.
proper patch format