Opened 4 years ago

Closed 3 years ago

#32502 closed Cleanup/optimization (fixed)

Replace SQLite schema table rebuild by ALTER functions when supported

Reported by: Simon Charette Owned by: Mariusz Felisiak
Component: Migrations Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description (last modified by Mariusz Felisiak)

Per https://www.sqlite.org/lang_altertable.html

This will leave only ALTER COLUMN and ADD/REMOVE CONSTRAINT that must be emulated on SQLite 3.35+

Change History (11)

comment:1 by Mariusz Felisiak, 4 years ago

Triage Stage: UnreviewedSomeday/Maybe
Version: 3.1master

Thanks Simon!

Marking as "Someday/Maybe" because it can we fully implemented after 3.35.0 release (such as #32501).

comment:2 by Mariusz Felisiak, 4 years ago

Triage Stage: Someday/MaybeAccepted

comment:3 by GitHub <noreply@…>, 3 years ago

In 4e249d1:

Refs #32502 -- Added SchemaEditor.prepare_default() on SQLite.

comment:4 by Mariusz Felisiak, 3 years ago

Has patch: set
Owner: changed from nobody to Mariusz Felisiak
Status: newassigned

comment:5 by Mariusz Felisiak <felisiak.mariusz@…>, 3 years ago

In 2f73e540:

Refs #32502 -- Avoided table rebuild when adding fields with no default on SQLite.

comment:6 by Mariusz Felisiak, 3 years ago

Description: modified (diff)
Has patch: unset

comment:7 by Mariusz Felisiak, 3 years ago

Owner: Mariusz Felisiak removed
Status: assignednew

comment:8 by Mariusz Felisiak, 3 years ago

Description: modified (diff)

comment:9 by Mariusz Felisiak, 3 years ago

Has patch: set
Owner: set to Mariusz Felisiak
Status: newassigned

comment:10 by GitHub <noreply@…>, 3 years ago

In 37028192:

Refs #32502 -- Avoided table rebuild when removing fields on SQLite 3.35.5+.

ALTER TABLE ... DROP COLUMN was introduced in SQLite 3.35+ however
a data corruption issue was fixed in SQLite 3.35.5.

comment:11 by Mariusz Felisiak, 3 years ago

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.
Back to Top