Opened 18 years ago
Closed 18 years ago
#3199 closed enhancement (duplicate)
[patch] Admin option 'js' always prepends settings.ADMIN_MEDIA_PREFIX
Reported by: | Jordi Funollet | Owned by: | Adrian Holovaty |
---|---|---|---|
Component: | contrib.admin | Version: | |
Severity: | normal | Keywords: | |
Cc: | Triage Stage: | Unreviewed | |
Has patch: | yes | Needs documentation: | no |
Needs tests: | no | Patch needs improvement: | no |
Easy pickings: | no | UI/UX: | no |
Description
Unconditionaly prepending settings.ADMIN_MEDIA_PREFIX
forces us to put application files in the Django tree. It would be easier to deploy applications if we could also prepend settings.MEDIA_URL
.
The attached patch uses this convention for the strings in Admin.js
:
- If you want
settings.ADMIN_MEDIA_PREFIX
, use a relative path (as usual). - If you want
settings.MEDIA_URL
, put an initial '/' on your string.
Attachments (2)
Change History (4)
by , 18 years ago
Attachment: | include_admin_script_with_option.diff added |
---|
by , 18 years ago
Attachment: | include_admin_script_with_option2.patch added |
---|
comment:1 by , 18 years ago
Summary: | Admin option 'js' always prepends settings.ADMIN_MEDIA_PREFIX → [patch] Admin option 'js' always prepends settings.ADMIN_MEDIA_PREFIX |
---|
comment:2 by , 18 years ago
Resolution: | → duplicate |
---|---|
Status: | new → closed |
Dupe of #2869
In my opinion, if you put in an absolute URL then it'd make more sense to just leave it alone rather than still trying to prepend something.
Note:
See TracTickets
for help on using tickets.
Same code, better patch format (I hope).