[patch] FileField does not allow modifications with upload_to set
|Reported by:||ido||Owned by:||adrian|
|Has patch:||yes||Needs documentation:||no|
|Needs tests:||no||Patch needs improvement:||no|
When you have FileField with the upload_to option; second time uploaded filename is always considered invalid.
Ie. you can create one instance, but you can't go back and edit this one and save. You always get:
Enter a valid filename.
This is very similar to ticket #2923
The issue is in: djang/db/models/fields/init__.py:def isWithinMediaRoot
this validator check explicitly if the uploaded file is in settings.MEDIA_ROOT
while part of the point of upload_to is that you can specify another directory.
i changed "settings.MEDIA_ROOT" to "self.upload_to or settings.MEDIA_ROOT"
to ensure that if upload_to is set, that location is used.