Opened 6 years ago

Last modified 8 months ago

#30032 assigned New feature

Allow expressions to be used for default

Reported by: Gavin Wahl Owned by: Johannes Maron
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Johannes Maron, Brian Helba Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

I have this field:

    foo = models.DateTimeField(default=timezone.now)

I would like to modify it to use TransactionNow instead:

    foo = models.DateTimeField(default=TransactionNow())

This migration operation is generated:

        migrations.AlterField(
            model_name='somemodel',
            name='foo',
            field=models.DateTimeField(default=django.contrib.postgres.functions.TransactionNow()),
        ),

When run, this error is thrown:

  File "./manage.py", line 29, in <module>
    execute_from_command_line(sys.argv)
  File "django/core/management/__init__.py", line 381, in execute_from_command_line
    utility.execute()
  File "django/core/management/__init__.py", line 375, in execute
    self.fetch_command(subcommand).run_from_argv(self.argv)
  File "django/core/management/base.py", line 316, in run_from_argv
    self.execute(*args, **cmd_options)
  File "django/core/management/base.py", line 353, in execute
    output = self.handle(*args, **options)
  File "django/core/management/base.py", line 83, in wrapped
    res = handle_func(*args, **kwargs)
  File "django/core/management/commands/migrate.py", line 203, in handle
    fake_initial=fake_initial,
  File "django/db/migrations/executor.py", line 117, in migrate
    state = self._migrate_all_forwards(state, plan, full_plan, fake=fake, fake_initial=fake_initial)
  File "django/db/migrations/executor.py", line 147, in _migrate_all_forwards
    state = self.apply_migration(state, migration, fake=fake, fake_initial=fake_initial)
  File "django/db/migrations/executor.py", line 244, in apply_migration
    state = migration.apply(state, schema_editor)
  File "django/db/migrations/migration.py", line 124, in apply
    operation.database_forwards(self.app_label, schema_editor, old_state, project_state)
  File "django/db/migrations/operations/fields.py", line 216, in database_forwards
    schema_editor.alter_field(from_model, from_field, to_field)
  File "django/db/backends/base/schema.py", line 523, in alter_field
    old_db_params, new_db_params, strict)
  File "django/db/backends/postgresql/schema.py", line 122, in _alter_field
    new_db_params, strict,
  File "django/db/backends/base/schema.py", line 626, in _alter_field
    old_default = self.effective_default(old_field)
  File "django/db/backends/base/schema.py", line 239, in effective_default
    return field.get_db_prep_save(default, self.connection)
  File "django/db/models/fields/__init__.py", line 790, in get_db_prep_save
    return self.get_db_prep_value(value, connection=connection, prepared=False)
  File "django/db/models/fields/__init__.py", line 1429, in get_db_prep_value
    value = self.get_prep_value(value)
  File "django/db/models/fields/__init__.py", line 1408, in get_prep_value
    value = super().get_prep_value(value)
  File "django/db/models/fields/__init__.py", line 1268, in get_prep_value
    return self.to_python(value)
  File "django/db/models/fields/__init__.py", line 1369, in to_python
    parsed = parse_datetime(value)
  File "django/utils/dateparse.py", line 106, in parse_datetime
    match = datetime_re.match(value)
TypeError: expected string or bytes-like object

If I create the field foo from scratch, with an AddField operation instead of AlterField, it works as expected.

I should be able to modify a field to use TransactionNow() as a default.

Change History (23)

comment:1 by Simon Charette, 6 years ago

Resolution: duplicate
Status: newclosed

Datebase level defaults are not supported yet, see #470.

comment:2 by Gavin Wahl, 6 years ago

This isn't a database level default, that ticket is to support defaults assigned by DDL. This is to support expressions as defaults.

comment:3 by Simon Charette, 6 years ago

Resolution: duplicate
Status: closednew
Summary: Can't alter the default of a DateTimeField to be TransactionNowAllow expressions to be used for default
Triage Stage: UnreviewedAccepted
Type: BugNew feature
Version: 2.1master

Sorry about the misinterpretation, #27222 seems related and I'm pretty sure there's another ticket related to allowing Now() to be used for default but I can't find it.

Tentatively accepting as a new feature request but as I said I'm pretty sure there is already another ticket tracking this.

comment:4 by Tim Graham, 6 years ago

Simon, you might be thinking of this PR which adds unofficial support for something like models.DateTimeField(default=Now) on PostgreSQL.

comment:5 by Simon Charette, 6 years ago

Thanks Tim, that's exactly what I had in mind. Should we close this ticket in favour of #29444 then?

comment:6 by Tim Graham, 6 years ago

I think we should keep this open as there will be more work to do even if that ticket is closed (adding support for other databases and making the support official with documentation).

comment:7 by Simon Charette, 6 years ago

Makes sense, thanks for chiming in.

comment:8 by Johannes Maron, 5 years ago

Cc: Johannes Maron added
Has patch: set
Owner: changed from nobody to Johannes Maron
Status: newassigned

comment:9 by Mariusz Felisiak, 5 years ago

Needs documentation: set
Needs tests: set

Simon left comments.

comment:10 by Johannes Maron, 4 years ago

Needs documentation: unset
Needs tests: unset

comment:11 by Johannes Maron, 4 years ago

Patch needs improvement: set

comment:12 by Johannes Maron, 4 years ago

Patch needs improvement: unset

comment:13 by Mariusz Felisiak, 4 years ago

Needs tests: set
Patch needs improvement: set

comment:14 by Johannes Maron, 4 years ago

Needs tests: unset
Patch needs improvement: unset

comment:15 by Johannes Maron, 4 years ago

Patch needs improvement: set

comment:16 by Johannes Maron, 4 years ago

Patch needs improvement: unset

comment:17 by InvalidInterrupt, 4 years ago

Patch needs improvement: set

comment:18 by Johannes Maron, 4 years ago

Patch needs improvement: unset

comment:19 by Mariusz Felisiak, 4 years ago

Patch needs improvement: set

Marking as "needs improvement" per Simon's comments.

comment:20 by Johannes Maron, 3 years ago

Patch needs improvement: unset

comment:21 by Mariusz Felisiak, 2 years ago

Patch needs improvement: set

comment:22 by Brian Helba, 2 years ago

Cc: Brian Helba added

comment:23 by Natalia Bidart, 8 months ago

Refreshed the PR with a rebase and conflict/style fixes, but it still needs work fixing failing tests.

Note: See TracTickets for help on using tickets.
Back to Top