Allow fields to be part of the RETURNING clause during INSERT
Dependency for #27452
The SQL RETURNING
statement is currently used for inserts of new objects. Mainly it is responsible to return the primary key in a single query.
That's great but currently in the postgres database backend this value is hard coded to only the primary key. I would like to propose to make this configurable.
There are plenty of uses cases for such a feature ultimately even enabling database defaults, but I would suggest to keep it very simple for now.
I would suggest to simply allow model fields to specify if they should be included in the returning statement or not. The default being not (except PK) to maintain the current behavior.
The implementation as well as the related code lines have been already discussed here:
https://github.com/django/django/pull/7525#issuecomment-354269077
I highly suggest to keep this a Postgres ONLY feature for now. That way we can see what sticks and consider extending this functionality into django.db
in the future after we have seen how it's being used and gathered feedback.
Change History
(29)
Owner: |
set to Johannes Maron
|
Status: |
new → assigned
|
Patch needs improvement: |
set
|
Triage Stage: |
Unreviewed → Accepted
|
Patch needs improvement: |
unset
|
Patch needs improvement: |
set
|
Patch needs improvement: |
unset
|
Type: |
New feature → Cleanup/optimization
|
Component: |
contrib.postgres → Database layer (models, ORM)
|
Patch needs improvement: |
set
|
Summary: |
Allow modification of RETURNING values in django.contrib.postgres → Allow fields to be part of the RETURNING clause during INSERT
|
Patch needs improvement: |
unset
|
Patch needs improvement: |
set
|
Patch needs improvement: |
unset
|
Patch needs improvement: |
set
|
Patch needs improvement: |
unset
|
Patch needs improvement: |
set
|
Patch needs improvement: |
unset
|
Triage Stage: |
Accepted → Ready for checkin
|
Has patch: |
unset
|
Triage Stage: |
Ready for checkin → Accepted
|
Has patch: |
set
|
Patch needs improvement: |
set
|
Patch needs improvement: |
unset
|
Resolution: |
→ fixed
|
Status: |
assigned → closed
|
PR