Opened 7 years ago
Closed 7 years ago
#29483 closed Cleanup/optimization (fixed)
Confirm support for GDAL 2.3
| Reported by: | Tim Graham | Owned by: | nobody |
|---|---|---|---|
| Component: | GIS | Version: | 2.0 |
| Severity: | Normal | Keywords: | |
| Cc: | Triage Stage: | Ready for checkin | |
| Has patch: | yes | Needs documentation: | no |
| Needs tests: | no | Patch needs improvement: | no |
| Easy pickings: | no | UI/UX: | no |
Description
I see a number of test failures with GDAL 2.3 (attached) but as in #28257, it might merely be a problem on my machine.
Attachments (2)
Change History (9)
by , 7 years ago
| Attachment: | gdal-2.3-failures.txt added |
|---|
by , 7 years ago
| Attachment: | 29483-docs.diff added |
|---|
comment:1 by , 7 years ago
comment:2 by , 7 years ago
This PR is solving the WGS 84 regex. I have no idea for the other failure, how GDAL can find a 31253 srid.
Note also that we should drop official support for GDAL 1.9 and 1.10 at least.
comment:5 by , 7 years ago
| Has patch: | set |
|---|
"EPSG:31253 Projected coordinate system for Austria east of 14°50'E of Greenwich (32°30'E of Ferro)." seems to make sense given a mention of Austria in the gas_leitung test data file.
comment:6 by , 7 years ago
| Triage Stage: | Accepted → Ready for checkin |
|---|
Ahhh.. I didn't notice that the second part of the test was using gas_leistung.shp. Makes sense now.
I just compiled a fresh 2.3 and obtained those 2 failures only:
====================================================================== FAIL: test_poly_multi (gis_tests.inspectapp.tests.OGRInspectTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/claude/checkouts/django-git/tests/gis_tests/inspectapp/tests.py", line 91, in test_poly_multi self.assertIn('geom = models.MultiLineStringField(srid=-1)', model_def) AssertionError: 'geom = models.MultiLineStringField(srid=-1)' not found in '# This is an auto-generated Django model module created by ogrinspect.\nfrom django.contrib.gis.db import models\n\n\nclass MyModel(models.Model):\n laenge = models.FloatField()\n breite = models.FloatField()\n nummer = models.BigIntegerField()\n geom = models.MultiLineStringField(srid=31253)' ====================================================================== FAIL: test05_geometries (gis_tests.gdal_tests.test_ds.DataSourceTest) Testing Geometries from Data Source Features. ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/claude/checkouts/django-git/tests/gis_tests/gdal_tests/test_ds.py", line 230, in test05_geometries self.assertIsNotNone(re.match(wgs_84_wkt_regex, g.srs.wkt)) AssertionError: unexpectedly None