Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#29287 closed Cleanup/optimization (wontfix)

Time to Remove: django.utils.deprecation.MiddlewareMixin

Reported by: Robert Roskam Owned by: nobody
Component: Core (Other) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Unreviewed
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

It was deprecated in 1.10: https://github.com/django/django/blame/104ee2fdae7fcd402396c709c91f5c84de6e4165/django/utils/deprecation.py

We've now had 1.11 and 2.0. Per our deprecation policy, it's actually overdue: https://docs.djangoproject.com/en/dev/internals/release-process/#deprecation-policy

Lets remove it for 2.1!

Change History (3)

comment:1 Changed 4 years ago by Tim Graham

Component: UncategorizedCore (Other)
Resolution: wontfix
Status: newclosed

It hasn't been deprecated (and therefore could not be removed immediately) and I see no advantage to removing it as it remains a useful class to avoid rewriting older middleware.

comment:2 Changed 4 years ago by Robert Roskam

Apologies! I though it just a holdout from the switch in 1.10.

comment:3 Changed 3 years ago by Adam Barnes

Is there a reason that mixin is in that module? It seems like it would be better placed in django.middleware.common...

Note: See TracTickets for help on using tickets.
Back to Top