Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#29286 closed Bug (fixed)

QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

Reported by: Mariusz Felisiak Owned by: Mariusz Felisiak
Component: Database layer (models, ORM) Version: 1.11
Severity: Release blocker Keywords:
Cc: Mariusz Felisiak Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

QuerySet.values_list() crashes when combining annotated and not-annotated querysets with union().

Regression in ​https://github.com/django/django/commit/a0c03c62a8ac586e5be5b21393c925afa581efaf.

Attachments (1)

29286.diff​ (1.2 KB) - added by Mariusz Felisiak 6 years ago.
Regression test.

Download all attachments as: .zip

Change History (10)

Changed 6 years ago by Mariusz Felisiak

Attachment: 29286.diff​ added

Regression test.

comment:1 Changed 6 years ago by Claude Paroz

Triage Stage: Unreviewed → Accepted

comment:2 Changed 6 years ago by Mariusz Felisiak

Owner: changed from nobody to Mariusz Felisiak
Status: new → assigned

comment:3 Changed 6 years ago by Mariusz Felisiak

Has patch: set
Version: 2.0 → 1.11

​PR

comment:4 Changed 6 years ago by Carlton Gibson

Triage Stage: Accepted → Ready for checkin

comment:5 Changed 6 years ago by Carlton Gibson

Triage Stage: Ready for checkin → Accepted

comment:6 Changed 6 years ago by Tim Graham

Triage Stage: Accepted → Ready for checkin

comment:7 Changed 6 years ago by GitHub <noreply@…>

Resolution: → fixed
Status: assigned → closed

In 0b66c3b:

Fixed #29286 -- Fixed column mismatch crash with QuerySet.values() or values_list() after combining an annotated and unannotated queryset with union(), difference(), or intersection().

Regression in a0c03c62a8ac586e5be5b21393c925afa581efaf.

Thanks Tim Graham and Carlton Gibson for reviews.

comment:8 Changed 6 years ago by Mariusz Felisiak <felisiak.mariusz@…>

In 3619d322:

[2.0.x] Fixed #29286 -- Fixed column mismatch crash with QuerySet.values() or values_list() after combining an annotated and unannotated queryset with union(), difference(), or intersection().

Regression in a0c03c62a8ac586e5be5b21393c925afa581efaf.

Thanks Tim Graham and Carlton Gibson for reviews.
Backport of 0b66c3b442875627fa6daef4ac1e90900d74290b from master

comment:9 Changed 6 years ago by Mariusz Felisiak <felisiak.mariusz@…>

In f89b11b8:

[1.11.x] Fixed #29286 -- Fixed column mismatch crash with QuerySet.values() or values_list() after combining an annotated and unannotated queryset with union(), difference(), or intersection().

Regression in a0c03c62a8ac586e5be5b21393c925afa581efaf.

Thanks Tim Graham and Carlton Gibson for reviews.

Backport of 0b66c3b442875627fa6daef4ac1e90900d74290b from master.

Note: See TracTickets for help on using tickets.
Back to Top