Opened 13 months ago

Last modified 11 hours ago

#28667 assigned Cleanup/optimization

Documentation for extending UserCreationForm doesn't work with UserAdmin

Reported by: Nathanael Gordon Owned by: eadhina
Component: contrib.auth Version: 1.11
Severity: Normal Keywords: add_fieldsets UserAdmin UserCreationForm Custom Auth User Model
Cc: Triage Stage: Accepted
Has patch: no Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: yes UI/UX: no

Description

In the docs for customising the Auth User model it does not fully outline the link between the UserCreationForm and the UserAdmin - specifically the fact that the UserAdmin's add_fieldsets will be used rather than the fields attribute in the Meta for the custom UserCreationForm.

At the end of this section (https://docs.djangoproject.com/en/1.11/topics/auth/customizing/#custom-users-and-the-built-in-auth-forms) it specifies that one can simply override the fields in the Meta of one's UserCreationForm. However, as the UserAdmin uses a custom get_fieldsets method which uses its add_fieldsets attribute instead, overriding fields does nothing.

Change History (6)

comment:1 Changed 13 months ago by Tim Graham

Summary: Lack of clear documentation for custom UserCreationForm when using a custom User modelDocumentation for extending UserCreationForm doesn't work with UserAdmin
Triage Stage: UnreviewedAccepted
Type: BugCleanup/optimization

comment:2 Changed 5 weeks ago by Hampus Dunström

Owner: changed from nobody to Hampus Dunström
Status: newassigned

comment:3 Changed 3 weeks ago by Hampus Dunström

I plan to be done with this at the end of October.

comment:4 Changed 3 weeks ago by Hampus Dunström

I'm having a hard time creating a test app with a UserCreationForm for a model based on the django.contrib.auth.admin.UserAdmin class. Is this not the class. Is there any example code anyone can show me?

At the end of this section (​https://docs.djangoproject.com/en/1.11/topics/auth/customizing/#custom-users-and-the-built-in-auth-forms) it specifies that one can simply override the fields in the Meta of one's UserCreationForm.

Above this example it is stated that it only works if the model is a simple subclass of AbstractUser. Do we want another example for UserAdmin or what are we looking for? Maybe I'm not the right person for this issue, I don't know. If any of you guys know anything or can clarify please let me know.

comment:5 Changed 23 hours ago by Hampus Dunström

Owner: Hampus Dunström deleted
Status: assignednew

comment:6 Changed 11 hours ago by eadhina

Owner: set to eadhina
Status: newassigned
Note: See TracTickets for help on using tickets.
Back to Top