[patch] BooleanField should use False as default (unless provided)

[Chris Beaven]

When creating models, BooleanFields which haven't explicitly been given a default have to be specifically set or a SQL error will occur (because the default value will be ). Simple solution is to force the default to False if no default is given.

# The model
class TestModel(models.Model):
    check = models.BooleanField()

# then in code..
t = TestModel()
t.save()  # will error, because the boolean field will return the default of '' instead of False

[Chris Beaven]

simple fix

[James Bennett]

I'm not sure I understand the bug here; any type of field should throw an error if it doesn't have null=True and you don't supply a value.

[Chris Beaven]

null=True doesn't make sense to me for BooleanFields because this are only two states it can be in - I'm not wanting a NullBooleanField. What does make sense is that if the default hasn't been specified as True for a boolean, you assume False.

Here are the local vars for the SQL error raised:

params = ('',)
sql	'INSERT INTO "project.test_model" ("check") VALUES (%s)'

[Chris Beaven]

a related ticket: #2890

[Bastian Kleineidam <calvin@…>]

You need the null=True to check if the value has been set or not. So BooleanField is actually a triple-state variable: True, False and unset.

If null=True should be the default case is of course highly application dependant. In my applications so far I always used null=True, but your mileage my vary.

[Chris Beaven]

Bastian, in Django there are two similar fields: BooleanField and NullBooleanField.

BooleanField can only have one of two states: True or False.

[Adrian Holovaty]

Closing this as wontfix for the reasons pointed out in the above comments.

[rlaager@…]

For the record, this was fixed at some point.