Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#28530 closed Bug (fixed)

SelectDateWidget localizes years in select box

Reported by: tpazderka Owned by: caleb logan
Component: Forms Version: 1.11
Severity: Release blocker Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Labels for year_choices for SelectDateWidget are assigned as integers and thus they are rendered with thousand separators in place.

They should be assigned as strings in order to bypass number formatting.

Change History (6)

comment:1 by Tim Graham, 8 years ago

Severity: Normal → Release blocker
Triage Stage: Unreviewed → Accepted

I didn't try to reproduce yet, but I suppose that's similar to #28303 and #28075.

in reply to:  1 comment:2 by tpazderka, 8 years ago

Replying to Tim Graham:

I didn't try to reproduce yet, but I suppose that's similar to #28303 and #28075.

Yes, this issue is a variation to both tickets.

comment:3 by caleb logan, 8 years ago

Owner: changed from nobody to caleb logan
Status: new → assigned

comment:4 by Tim Graham, 8 years ago

Has patch: set
Triage Stage: Accepted → Ready for checkin

​PR

comment:5 by Tim Graham <timograham@…>, 8 years ago

Resolution: → fixed
Status: assigned → closed

In 9e2bf65d:

Fixed #28530 -- Prevented SelectDateWidget from localizing years in output.

comment:6 by Tim Graham <timograham@…>, 8 years ago

In 3bb03df0:

[1.11.x] Fixed #28530 -- Prevented SelectDateWidget from localizing years in output.

Backport of 9e2bf65d6a5dc3b53db84f4839652f0d154349ee from master

Note: See TracTickets for help on using tickets.
Back to Top