Opened 4 years ago

Closed 3 years ago

#28306 closed Cleanup/optimization (fixed)

Complete test coverage for django/utils/lorem_ipsum.py

Reported by: Idan Melamed Owned by: luiscberrocal
Component: Utilities Version: 1.11
Severity: Normal Keywords: Testing, lorem ipsum
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

Hi people,

I added a few more tests in tests_lorem_ipsum.py and increased the coverage for it to 100%.
Also changed the code a bit in lorem_ipsum.py.

I read the the documentation for contributing, and couldn't find out clear information on what to do in my case.

How do I continue now?
Do I create a pull request?
If so, how should I name my branch?

Kindly,
Idan.

Change History (4)

comment:1 Changed 4 years ago by Tim Graham

Component: Testing frameworkUtilities
Summary: Added tests in tests_lorem_ipsum.pyComplete test coverage for django/utils/lorem_ipsum.py
Triage Stage: UnreviewedAccepted

See Working with Git and GitHub if you need help with that. The branch name isn't important but see the PatchReviewChecklist for things to check.

You can create two pull requests, one for the additional test and one for code refactorings.

comment:2 Changed 4 years ago by luiscberrocal

Owner: changed from nobody to luiscberrocal
Status: newassigned

comment:3 Changed 4 years ago by Flávio Juvenal

Has patch: set

PR available now: https://github.com/django/django/pull/8932
Made by luiscberrocal. Reviewed by me. Looks fine!

comment:4 Changed 3 years ago by Tim Graham <timograham@…>

Resolution: fixed
Status: assignedclosed

In 54f7aa04:

Fixed #28306 -- Completed test coverage for django.utils.lorem_ipsum.

Thanks Idan Melamed for the original patch.

Note: See TracTickets for help on using tickets.
Back to Top