Opened 7 years ago

Closed 7 years ago

#28258 closed Cleanup/optimization (fixed)

Optimize Oracle introspection by using LISTAGG

Reported by: Mariusz Felisiak Owned by: Mariusz Felisiak
Component: Database layer (models, ORM) Version: dev
Severity: Normal Keywords:
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

It's more optimal to use ​LISTAGG in Oracle introspection instead of ordering and multiple rows per each constraint.

Change History (4)

comment:1 by Mariusz Felisiak, 7 years ago

Owner: changed from nobody to Mariusz Felisiak
Status: new → assigned

​PR

comment:2 by Tim Graham, 7 years ago

Triage Stage: Unreviewed → Ready for checkin

Before PR (on Oracle):

migrations.test_operations.OperationTests ... 198 sec
inspectdb.tests ... 146 sec
introspection.tests ... 33 sec
schema.tests ... 363 sec

after PR (on Oracle):

migrations.test_operations.OperationTests ... 101 sec
inspectdb.tests ... 41 sec
introspection.tests ... 29 sec
schema.tests ... 146 sec

comment:3 by Mariusz Felisiak, 7 years ago

For comparison:
11,418 tests -> took 27 min (before PR),
11,424 tests -> took 18 min (after PR).

comment:4 by Mariusz Felisiak <felisiak.mariusz@…>, 7 years ago

Resolution: → fixed
Status: assigned → closed

In 8149bd0:

Fixed #28258 -- Optimized Oracle introspection by using LISTAGG.

Thanks Tim Graham and Jani Tiainen for reviews.

Note: See TracTickets for help on using tickets.
Back to Top