Opened 6 years ago

Closed 3 years ago

Last modified 3 years ago

#28184 closed New feature (fixed)

FileField storage param should allow a callable

Reported by: miigotu Owned by: miigotu
Component: File uploads/storage Version: dev
Severity: Normal Keywords: callable storage filefield
Cc: Triage Stage: Ready for checkin
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: no
Easy pickings: no UI/UX: no

Description

For example, when using S3 I may have a field that I want to use private acl, while other fields are not using private storage. Locally or in different deployments I may not be using S3, and the storage is different.

Change History (12)

comment:1 Changed 6 years ago by Tim Graham

Easy pickings: unset
Patch needs improvement: set
Summary: FileField storages param should allow a callable → FileField storage param should allow a callable
Triage Stage: Unreviewed → Accepted

Tentatively accepting. This idea also came up in #24648. The PR has test failures and documentation changes are also required. See the PatchReviewChecklist.

comment:2 Changed 6 years ago by miigotu

Patch needs improvement: unset

Improved patch, passes all tests now.

comment:3 Changed 5 years ago by Carlton Gibson

Needs documentation: set
Patch needs improvement: set

comment:4 Changed 5 years ago by Carlton Gibson

Left some comments on PR.

comment:5 in reply to:  4 Changed 5 years ago by miigotu

Replying to Carlton Gibson:

Left some comments on PR.

PR Updated, please review

comment:6 Changed 5 years ago by miigotu

Needs documentation: unset
Patch needs improvement: unset

comment:7 Changed 5 years ago by miigotu

Version: 1.11 → master

comment:8 Changed 5 years ago by Carlton Gibson

Patch needs improvement: set

comment:9 Changed 3 years ago by Carlton Gibson

Patch needs improvement: unset

comment:10 Changed 3 years ago by Carlton Gibson

Triage Stage: Accepted → Ready for checkin

comment:11 Changed 3 years ago by Carlton Gibson <carlton@…>

Resolution: → fixed
Status: assigned → closed

In 210657b7:

Fixed #28184 -- Allowed using a callable for FileField and ImageField storage.

comment:12 Changed 3 years ago by Carlton Gibson <carlton@…>

In 94b32a2:

Refs #28184 -- Added test for FileField storage default.

Co-authored-by: miigotu <miigotu@…>

Note: See TracTickets for help on using tickets.
Back to Top