Opened 17 months ago

Last modified 7 months ago

#28184 assigned New feature

FileField storage param should allow a callable

Reported by: miigotu Owned by: miigotu
Component: File uploads/storage Version: master
Severity: Normal Keywords: callable storage filefield
Cc: Triage Stage: Accepted
Has patch: yes Needs documentation: no
Needs tests: no Patch needs improvement: yes
Easy pickings: no UI/UX: no

Description

For example, when using S3 I may have a field that I want to use private acl, while other fields are not using private storage. Locally or in different deployments I may not be using S3, and the storage is different.

Change History (8)

comment:1 Changed 16 months ago by Tim Graham

Easy pickings: unset
Patch needs improvement: set
Summary: FileField storages param should allow a callableFileField storage param should allow a callable
Triage Stage: UnreviewedAccepted

Tentatively accepting. This idea also came up in #24648. The PR has test failures and documentation changes are also required. See the PatchReviewChecklist.

comment:2 Changed 16 months ago by miigotu

Patch needs improvement: unset

Improved patch, passes all tests now.

comment:3 Changed 7 months ago by Carlton Gibson

Needs documentation: set
Patch needs improvement: set

comment:4 Changed 7 months ago by Carlton Gibson

Left some comments on PR.

comment:5 in reply to:  4 Changed 7 months ago by miigotu

Replying to Carlton Gibson:

Left some comments on PR.

PR Updated, please review

comment:6 Changed 7 months ago by miigotu

Needs documentation: unset
Patch needs improvement: unset

comment:7 Changed 7 months ago by miigotu

Version: 1.11master

comment:8 Changed 7 months ago by Carlton Gibson

Patch needs improvement: set
Note: See TracTickets for help on using tickets.
Back to Top