Add a way to delete directories through the file Storage API

[jedie]

It seems not possible to cleanup orphaned directories via storage API [1]

The problem: The default filesystem storage will call os.remove(name) on storage.delete(name) usage. So it's only possible to delete a file and not a directory.

Usecase:
I store files (via models.FileField) in a sub-directory with a random token (via upload_to callback).
I delete the file via post_delete model signal and call storage.delete(file.path)
Now i can only delete the sub directory if i implement a own routine and use os.rmdir(path) if the default filesystem storage is used.

[1] ​https://docs.djangoproject.com/en/dev/ref/files/storage/

[Tim Graham]

I wonder if it would be feasible and a good idea to allow FileSystemStorage.delete() to distinguish between files and directories and issue os.remove() or os.rmdir() as necessary?

[ChillarAnand]

Fixed in ​PR

[Tim Graham <timograham@…>]

In e402556:

Fixed #27836 -- Allowed FileSystemStorage.delete() to remove directories.

[Tim Graham <timograham@…>]

In 9cbf4869:

Refs #27836 -- Fixed cleanup exception in file_storage test.

TemporaryDirectory tries to delete the directory that was already removed.